[pfcwd]: Configuration commands #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'start/stop' commands Create 'show' group Move 'stats' to 'show' and add 'show config' Signed-off-by: marian-pritsak <[email protected]>
jleveque
approved these changes
Nov 7, 2017
|
Depends on: sonic-net/sonic-swss#374 |
lguohan
approved these changes
Nov 9, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
…t test coverage (sonic-net#147) - Refactor ledd to allow for more thorough unit testing - Remove infinite loop from `run()` method to allow unit testing of the method. Instead, call the `run()` method in an infinite loop in `main()` - Increase overall ledd unit test coverage from 48% to 93%. Previous unit test coverage: ``` ----------- coverage: platform linux, python 3.7.3-final-0 ----------- Name Stmts Miss Cover ---------------------------------- scripts/ledd 66 34 48% Coverage HTML written to dir htmlcov Coverage XML written to file coverage.xml ``` Unit test coverage with this patch: ``` ----------- coverage: platform linux, python 3.7.3-final-0 ----------- Name Stmts Miss Cover ---------------------------------- scripts/ledd 72 5 93% Coverage HTML written to dir htmlcov Coverage XML written to file coverage.xml ```
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
This PR provides the support for error checking the returned values from eeprom read for sonic_y_cable, particularly if garbage/non expected value/values are returned. What is the motivation for this PR? support for error checking the returned values from eeprom read for sonic_y_cable, particularly if garbage/non expected values are returned. How did you do it? added code after read_eeprom api's to validate the returned values. Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'start/stop' commands
Create 'show' group
Move 'stats' to 'show' and add 'show config'
Signed-off-by: marian-pritsak [email protected]