[sfputil] Gracefully handle improper 'specification_compliance' field (…

…#1741) Signed-off-by: Prince George <[email protected]>
sonic-net · Aug 26, 2021 · c15fb8f · c15fb8f
1 parent 39350f8
commit c15fb8f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/sfputil/main.py b/sfputil/main.py
@@ -264,10 +264,15 @@ def convert_sfp_info_to_output_string(sfp_info_dict):
                 output += '{}{}: {}\n'.format(indent, QSFP_DATA_MAP[key], sfp_info_dict[key])
             else:
                 output += '{}{}:\n'.format(indent, QSFP_DATA_MAP['specification_compliance'])
-                spefic_compliance_dict = eval(sfp_info_dict['specification_compliance'])
-                sorted_compliance_key_table = natsorted(spefic_compliance_dict)
+
+            spec_compliance_dict = {}
+            try:
+                spec_compliance_dict = ast.literal_eval(sfp_info_dict['specification_compliance'])
+                sorted_compliance_key_table = natsorted(spec_compliance_dict)
                 for compliance_key in sorted_compliance_key_table:
-                    output += '{}{}: {}\n'.format((indent * 2), compliance_key, spefic_compliance_dict[compliance_key])
+                    output += '{}{}: {}\n'.format((indent * 2), compliance_key, spec_compliance_dict[compliance_key])
+            except ValueError as e:
+                output += '{}N/A\n'.format((indent * 2))
         else:
             output += '{}{}: {}\n'.format(indent, QSFP_DATA_MAP[key], sfp_info_dict[key])