Add test for IPv4/IPv6 tunnel creation #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Jul 27, 2018
|
|
||
| tunnel_sai_obj = tunnels[0] | ||
|
|
||
| status, fvs = tunnel_table.get(tunnel_sai_obj) |
There was a problem hiding this comment.
we probably need to assert status == true here
lguohan
reviewed
Jul 27, 2018
| expected_dscp_mode = self.dscp_modes_map[dscp_mode] | ||
| expected_ttl_mode = self.ttl_modes_map[ttl_mode] | ||
|
|
||
| for field, value in fvs: |
There was a problem hiding this comment.
we need to access the len(fvs) since some attribute might be missing.
There was a problem hiding this comment.
Added assert len(fvs) == expected number of fields
Signed-off-by: stepanb <[email protected]>
stepanblyschak
force-pushed
the
tunnel_vs_test
branch
from
8627c0e to
f27d7f4
Compare
|
Retest this please |
1 similar comment
|
Retest this please |
lguohan
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: stepanb [email protected]
What I did
I added VS test for IPv4/IPv6 tunnel creation
Why I did it
There was no VS test for tunnel creation, so I added it
How I verified it
Run VS tests