Fix portmgr write partial port config to app DB issue. #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Oct 2, 2024
| // Port configuration is handled by the orchagent. If the configuration is written to the APP DB using | ||
| // multiple Redis write commands, the orchagent may receive a partial configuration and create a port | ||
| // with incorrect settings. | ||
| field_values.emplace_back("mtu", mtu); |
There was a problem hiding this comment.
there are defaults in orchagent for these attributes. are you saying those defaults are different from this ones?
There was a problem hiding this comment.
Hi @prsunny , the problem here is the invalid admin status missing in database, which cause the port been created:
2024-09-20.02:50:54.253615|PORT_TABLE:Ethernet1000|SET|lanes:1000,1001,1002,1003|speed:100000|mtu:9100
dgsudharsan
approved these changes
Oct 2, 2024
qiluo-msft
approved these changes
Oct 4, 2024
10 tasks
|
@bingwang-ms for viz |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Oct 14, 2024
Fix portmgr write partial port config to app DB issue. Why I did it Test case test_add_remove_neg_admin_status unstable.
|
Cherry-pick PR to 202405: #3327 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 14, 2024
Fix portmgr write partial port config to app DB issue. Why I did it Test case test_add_remove_neg_admin_status unstable.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
Fix portmgr write partial port config to app DB issue. Why I did it Test case test_add_remove_neg_admin_status unstable.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
Fix portmgr write partial port config to app DB issue. Why I did it Test case test_add_remove_neg_admin_status unstable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix portmgr write partial port config to app DB issue.
Why I did it
Test case test_add_remove_neg_admin_status unstable.
Work item tracking
How I did it
Improve portmgr code to write all port config with one API call.
How to verify it
Pass all UT.
Manually verify issue fixed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Fix portmgr write partial port config to app DB issue.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)