[vnetorch] Advertise vnet tunnel routes #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2021 21:56
prsunny
reviewed
Dec 2, 2021
orchagent/vnetorch.cpp
Outdated
| @@ -1563,12 +1564,36 @@ void VNetRouteOrch::postRouteState(const string& vnet, IpPrefix& ipPrefix, NextH | |||
| fvVector.emplace_back("state", route_state); | |||
|
|
|||
| state_vnet_rt_tunnel_table_->set(state_db_key, fvVector); | |||
|
|
|||
| if (route_state == "active") | |||
There was a problem hiding this comment.
Advertisement must be done only if the VNET attribute is set to advertise . It should not break the previous behavior of default as no-advertise.
There was a problem hiding this comment.
Added support for advertise_prefix attribute and updated vs tests.
|
@shi-su should this PR go to 202111 as well? if so can you please add a label? |
prsunny
approved these changes
Jan 11, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Jan 17, 2022
What I did Advertise active vnet tunnel routes. Why I did it The overlay routes programmed on the device need to be advertised to BGP peers. This PR aims to meet this requirement. How I verified it Add an entry in ADVERTISE_NETWORK_TABLE for active overlay routes
shi-su
added a commit
to shi-su/sonic-swss
that referenced
this pull request
Jan 21, 2022
What I did Advertise active vnet tunnel routes. Why I did it The overlay routes programmed on the device need to be advertised to BGP peers. This PR aims to meet this requirement. How I verified it Add an entry in ADVERTISE_NETWORK_TABLE for active overlay routes
shi-su
added a commit
that referenced
this pull request
Jan 26, 2022
…oint health monitoring (#2104) What I did Cherry-pick changes in #1960, #1883, #1955, #2058 Changes in #1960: Add functions to create/remove next hop groups for vnet tunnel routes. Count the reference count of next hop groups to create and remove as needed. Share the counter of next hop groups with routeorch. Add vs test Changes in #1883: Implement bfdorch to program hardware BFD sessions via bfd SAI. Add vs test for bfd sessions. Changes in #1955: Add functions to create/remove next hop groups for vnet tunnel routes. Count the reference count of next hop groups to create and remove as needed. Share the counter of next hop groups with routeorch. Adapt route endpoint according to the BFD state of endpoints. Changes in #2058: Advertise active vnet tunnel routes. Why I did it To add support for overlay ECMP with endpoint health monitoring.
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
What I did Advertise active vnet tunnel routes. Why I did it The overlay routes programmed on the device need to be advertised to BGP peers. This PR aims to meet this requirement. How I verified it Add an entry in ADVERTISE_NETWORK_TABLE for active overlay routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Advertise active vnet tunnel routes.
Why I did it
The overlay routes programmed on the device need to be advertised to BGP peers. This PR aims to meet this requirement.
How I verified it
Add an entry in
ADVERTISE_NETWORK_TABLEfor active overlay routesDetails if related