Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reclaim buffer][202106] Common code update #2038

Closed
wants to merge 10 commits into from
Closed

[Reclaim buffer][202106] Common code update #2038

wants to merge 10 commits into from

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Nov 19, 2021 •
edited
Loading

This is to backport #1996 to 202106.

What I did
Common code update for reclaiming buffer.

  1. Loading zero_profiles when dynamic buffer manager starting
    The buffer manager won't consume it for now. This is to pass Azure CI.
  2. Support removing a buffer pool.
  3. Support exposing maximum PGs and queues per port
  4. Support transmit between bitmap and map string
  5. Change the log severity from ERROR to NOTICE when parsing buffer profile from buffer profile list failed. Typically this can be resolved by retrying.
    The severity of similar log when parsing buffer PG and queue is already NOTICE.

Signed-off-by: Stephen Sun [email protected]

Why I did it

To split large PR into smaller ones and help pass CI.

How I verified it

vs test and regression test.

Details if related

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs mentioned this pull request Nov 19, 2021
Closed
5 tasks
@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the reclaim-buffer-base-202106 branch from e3be1c7 to c858989 Compare November 24, 2021 08:55
@stephenxs stephenxs mentioned this pull request Nov 24, 2021
Merged
5 tasks
@stephenxs stephenxs marked this pull request as ready for review November 24, 2021 13:27
@stephenxs stephenxs requested a review from prsunny as a code owner November 24, 2021 13:27
@stephenxs
Copy link
Collaborator Author

Checker failed due to Unable to fetch sonic swss common deb

@stephenxs stephenxs requested a review from neethajohn November 24, 2021 13:28
@stephenxs stephenxs mentioned this pull request Nov 25, 2021
Merged
@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs mentioned this pull request Dec 3, 2021
Closed
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

With LGTM using 202106 branch of swss-common and sairedis, LGTM build merge passed.
Will open another PR to fix the LGTM and revert it in this PR.

@stephenxs
Copy link
Collaborator Author

LGTM depends on PR #2074.

@arlakshm
Copy link
Contributor

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

Currently, the PR depends on #2118 for the vstest failure.

@stephenxs
Copy link
Collaborator Author

LGTM failure: looks like the same as that on master.

[2022-02-25 05:58:24] [build-stdout] �[92mProcessing saivlan_8h.xml�[0m
[2022-02-25 05:58:24] [build-stdout] �[92mProcessing saiwred_8h.xml�[0m
[2022-02-25 05:58:24] [build-stdout] �[91mERROR: invalid type '' for SAI_ACL_COUNTER_ATTR_TABLE_ID�[0m
[2022-02-25 05:58:24] [build-stdout] �[91mERROR: flags are not defined for SAI_ACL_COUNTER_ATTR_TABLE_ID�[0m
[2022-02-25 05:58:24] [build-stdout] �[91mERROR: FATAL ERROR === MUST FIX === : Can't use an undefined value as an ARRAY reference at parse.pl line 1464.
[2022-02-25 05:58:24] [build-stdout] �[0m
[2022-02-25 05:58:24] [build-stderr] make[3]: *** [Makefile:102: saimetadata.h] Error 1
[2022-02-25 05:58:24] [build-stdout] make[3]: Leaving directory '/opt/src/sonic-sairedis/SAI/meta'
[2022-02-25 05:58:24] [build-stderr] make[2]: *** [Makefile:1354: saimeta-gen] Error 2
[2022-02-25 05:58:24] [build-stdout] make[2]: Leaving directory '/opt/src/sonic-sairedis/meta'
[2022-02-25 05:58:24] [build-stderr] make[1]: *** [Makefile:433: install-recursive] Error 1
[2022-02-25 05:58:24] [build-stdout] make[1]: Leaving directory '/opt/src/sonic-sairedis'
[2022-02-25 05:58:24] [build-stderr] dh_auto_install: error: make -j1 install DESTDIR=/opt/src/sonic-sairedis/debian/tmp AM_UPDATE_INFO_DIR=no returned exit code 2
[2022-02-25 05:58:24] [build-stderr] make: *** [debian/rules:59: binary-syncd-vs] Error 25

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs closed this Mar 28, 2022
@stephenxs stephenxs deleted the reclaim-buffer-base-202106 branch August 16, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neethajohn neethajohn neethajohn approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenxs @mssonicbld @liat-grozovik @arlakshm @neethajohn