Cache routes for single nexthop for faster retrieval #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
shi-su
reviewed
Sep 22, 2021
shi-su
reviewed
Sep 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
shi-su
previously approved these changes
Sep 22, 2021
shi-su
previously approved these changes
Sep 24, 2021
shi-su
approved these changes
Sep 24, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Created a map to store single nexthop routes. This is for faster retrieval when you've to fetch the routes for a particular nexthop. No changes to ECMP route handling.
This was referenced Oct 6, 2021
vaibhavhd
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Oct 9, 2021
[Submodule advance sonic-swss] Include below commits to master image: Cache routes for single nexthop for faster retrieval sonic-net/sonic-swss#1922 Reduce route count for route perf test (sonic-net/sonic-swss#1928) [pytest]: Re-use DVS container when possible (sonic-net/sonic-swss#1816) [PORTSYNCD] when no ports on config db on init, continue and set Port… (sonic-net/sonic-swss#1861) [gearbox] Add gearbox unit test (sonic-net/sonic-swss#1920) Reverted skipped test_buffer_dynamic test cases (sonic-net/sonic-swss#1937) Revert "[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STA… (sonic-net/sonic-swss#1945)
judyjoseph
pushed a commit
that referenced
this pull request
Oct 11, 2021
* Created a map to store single nexthop routes. This is for faster retrieval when you've to fetch the routes for a particular nexthop. No changes to ECMP route handling.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Created a map to store single nexthop routes. This is for faster retrieval when you've to fetch the routes for a particular nexthop. No changes to ECMP route handling.
This is an optimization and the existing VS test covers the code for add flow. Set flow is covered with new test case.
Why I did it
Faster retrieval of route when a particular nexthop state changes. This avoid looping through all the routes to find a matching nexthop.
How I verified it
Tested on DUT:
Details if related