[gearbox] Set port speed to SAI_PORT_ATTR_SPEED for gearbox #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a unit test that cover this part? can you add swss vs test? |
jimmyzhai
reviewed
Aug 19, 2021
orchagent/portsorch.cpp
Outdated
| @@ -1839,23 +1835,19 @@ bool PortsOrch::setGearboxPortAttr(Port &port, dest_port_type_t port_type, sai_p | |||
|
|
|||
| // Gearbox expects speed per lane | |||
There was a problem hiding this comment.
Please remove the line of comment "// Gearbox expects speed per lane".
jimmyzhai
approved these changes
Aug 26, 2021
|
The re-run of test vstest is successful. |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…t#1785) * Set port speed to SAI_PORT_ATTR_SPEED for gearbox system-side/line-side ports. Lane speed was set before this change.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…sonic-net#1785) What I did Verify database integrity before proceeding with warm reboot or fast reboot. This integrity check uses a JSON schema to validate DBs. To start with, only counters_db's table COUNTERS_PORT_NAME_MAP presence is verified. But, this list can advance in future. The test logic is designed to be generic; any more databases or tables within them can be just added to schema list, and the verification logic needs no change. How I did it Added a JSON schema, and generic schema validation logic.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
The script was added in the PR sonic-net#1785 which did not add this script to the setup.py script. Added the check_db_integrity script to setup.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Set port speed to SAI_PORT_ATTR_SPEED for gearbox system-side/line-side ports. Lane speed was set before this change.
Why I did it
According to the example of "Creating ASIC Ports with 100G" in the SAI design doc: https://github.com/opencomputeproject/SAI/blob/master/doc/macsec-gearbox/SAI_Gearbox_API_Proposal-v1.0.docx, port speed should be set to SAI_PORT_ATTR_SPEED. However, the current code applies the lane speed to it. The SAI-based driver for the gearbox chip on Arista devices is assuming port speed for SAI_PORT_ATTR_SPEED, so we hope to submit this change to fix the issue we are facing.
How I verified it
Tested that traffic passing through the ports works and no related errors in syslog.
Details if related