Add failure handling for SAI get operations #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jun 30, 2021
qiluo-msft
reviewed
Jul 2, 2021
orchagent/natorch.cpp
Outdated
| @@ -115,6 +115,7 @@ NatOrch::NatOrch(DBConnector *appDb, DBConnector *stateDb, vector<table_name_wit | |||
| if (status != SAI_STATUS_SUCCESS) | |||
| { | |||
| SWSS_LOG_NOTICE("Failed to get the SNAT available entry count, rv:%d", status); | |||
| handleSaiGetStatus(SAI_API_SWITCH, status); | |||
There was a problem hiding this comment.
I thought the change is mainly intended to give enough warning when the SAI API is not implemented. Yet I do agree that this is not necessary for the scenarios where it could proceed without successful execution of the get operations. Removed the handling here and a few other similar scenarios.
qiluo-msft
previously approved these changes
Jul 4, 2021
|
Please fix the conflicts |
added 10 commits
July 5, 2021 00:42
Done. Please help review again. Thanks. |
qiluo-msft
approved these changes
Jul 6, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Aug 10, 2021
What I did Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status. Why I did it Enable custom failure handling for SAI get operations.
shi-su
added a commit
to shi-su/sonic-swss
that referenced
this pull request
Aug 17, 2021
What I did Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status. Why I did it Enable custom failure handling for SAI get operations.
shi-su
added a commit
to shi-su/sonic-swss
that referenced
this pull request
Aug 17, 2021
What I did Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status. Why I did it Enable custom failure handling for SAI get operations.
shi-su
added a commit
that referenced
this pull request
Aug 18, 2021
What I did Backport SAI failure handling related commits into the 202012 branch. The following is a list of backported commits: 941875a Deactivate mirror session only when session status is true in updateLagMember (#1666) be12482 Ignore ALREADY_EXIST error in FDB creation (#1815) c9c1aa2 Add failure handling for SAI get operations (#1768) 47b4276 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (#1786) db9238f Add failure notification for orchagent (#1665) fc8e43f [synchronous mode] Add failure notification for SAI failures in synchronous mode (#1596) Why I did it 202012 image needs to include failure handling mechanism for enough notification in the presence of SAI failures.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
What I did Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status. Why I did it Enable custom failure handling for SAI get operations.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ers enablement after fast-reboot (sonic-net#1768) #### What I did Set flex counters delay indicator to prevent flex counters enablement after fast-reboot. #### How I did it Modify config DB json file with 'true' status for delay of flex counters indicator. #### How to verify it Run fast-reboot and observe counters are created only when enable_counters script is called, even if the tables are present in config DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status.
Why I did it
Enable custom failure handling for SAI get operations.
How I verified it
Details if related