optimize stream operator

Signed-off-by: Ze Gan <[email protected]>
sonic-net · Dec 28, 2020 · 45af9c2 · 45af9c2
1 parent a7f5acd
commit 45af9c2
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 40 deletions.
diff --git a/common/Makefile.am b/common/Makefile.am
@@ -63,8 +63,7 @@ libswsscommon_la_SOURCES = \
     subscriberstatetable.cpp  \
     timestamp.cpp             \
     warm_restart.cpp          \
-    redisutility.cpp          \
-    boolean.cpp
+    redisutility.cpp
 
 libswsscommon_la_CXXFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(LIBNL_CFLAGS)
 libswsscommon_la_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(LIBNL_CPPFLAGS)

diff --git a/common/boolean.cpp b/common/boolean.cpp
diff --git a/common/boolean.h b/common/boolean.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include <iostream>
+#include <ios>
 
 namespace swss
 {
@@ -28,12 +29,34 @@ class AlphaBoolean : public Boolean
     }
 };
 
-std::ostream &operator<<(std::ostream &out, const Boolean &b);
+static inline std::ostream &operator<<(std::ostream &out, const AlphaBoolean &b)
+{
+    bool value = b;
+    out << std::boolalpha << value;
+    return out;
+}
 
-std::istream &operator>>(std::istream &in, Boolean &b);
+static inline std::istream &operator>>(std::istream &in, AlphaBoolean &b)
+{
+    bool value = false;
+    in >> std::boolalpha >> value;
+    b = value;
+    return in;
+}
 
-std::ostream &operator<<(std::ostream &out, const AlphaBoolean &b);
+static inline std::ostream &operator<<(std::ostream &out, const Boolean &b)
+{
+    bool value = b;
+    out << value;
+    return out;
+}
 
-std::istream &operator>>(std::istream &in, AlphaBoolean &b);
+static inline std::istream &operator>>(std::istream &in, Boolean &b)
+{
+    bool value = false;
+    in >> value;
+    b = value;
+    return in;
+}
 
 }