Workaround getSwitchType failure due to NPU SAI not yet supporting it #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Jul 27, 2020
gechiang
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 28, 2020
Advanced Submodule head of Sonic-Sairedis and picked up the following changes: Workaround getSwitchType failure due to NPU SAI not yet supporting it (#647) sonic-net/sonic-sairedis#647 Adding support for new SAI API sai_query_attribute_capability() (#645) sonic-net/sonic-sairedis#645 [syncd] ARM32 bit fixes, for 64bit printf format specifier. (#643) Signed-off-by: Rajkumar Pennadam Ramamoorthy <[email protected]> sonic-net/sonic-sairedis#643 [syncd] Add support for synchronous bulk api (#640) sonic-net/sonic-sairedis#640
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #632 is causing BRCM DUT not able to bootup.
The newly introduced getSwithType at SONiC boot time to support BRCM GearBox SAI is not yet supported by ASIC SAI result to error that causes Orchagent termination at boot up.
This workaround is added to default the switch type to NPU in case receiving a failure from the SAI call so that BRCM DUT can boot up successfully.
I have validated this change using the Force10-S6000 (BRCM ASIC).
Kamil has also reviewed and OKed this change.