Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vslib]: Add SAI_PORT_ATTR_OPER_SPEED get #1107

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

Pterosaur
Copy link
Contributor

@Pterosaur Pterosaur commented Aug 20, 2022

Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed

Signed-off-by: Ze Gan [email protected]

@Pterosaur Pterosaur changed the title [vslib]: Add SAI_PORT_ATTR_OPER_SPEED support [vslib]: Add SAI_PORT_ATTR_OPER_SPEED get Aug 20, 2022
@Pterosaur Pterosaur requested a review from kcudnik August 20, 2022 05:18
@Pterosaur Pterosaur force-pushed the oper_speed_in_vslib branch from 4420bed to 3097960 Compare August 20, 2022 12:05
@Pterosaur
Copy link
Contributor Author

@kcudnik I think the failure in LGTM isn't introduced by this PR.

@Pterosaur Pterosaur force-pushed the oper_speed_in_vslib branch 4 times, most recently from b7054f0 to ecf607d Compare August 20, 2022 16:14
@Pterosaur Pterosaur force-pushed the oper_speed_in_vslib branch from ecf607d to 912082a Compare August 20, 2022 22:51
@Pterosaur
Copy link
Contributor Author

/azp run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Contributor Author

@kcudnik Could you please merge this PR? Because it is needed by advancing swss.

@kcudnik kcudnik merged commit 594b242 into sonic-net:master Sep 2, 2022
mlorrillere added a commit to mlorrillere/sonic-buildimage that referenced this pull request Sep 8, 2022
* 660a920 [Chassis] Create fabric ports for switch_type fabric. (sonic-net/sonic-sairedis#1114)
* 8140c22 Fix issue: bulk counter feature cannot compile on platforms having no sai_bulk_object_get_stats/sai_bulk_object_clear_stats (sonic-net/sonic-sairedis#1105)
* 0aa60f5 [lgtm] Add uuid library (sonic-net/sonic-sairedis#1119)
* e8a01a8 Add retry on zmq functions if fail with EINTR. (sonic-net/sonic-sairedis#1109)
* 594b242 Add SAI_PORT_ATTR_OPER_SPEED support (sonic-net/sonic-sairedis#1107)
* 4c9e048 Add Xsight specific syncd start options (sonic-net/sonic-sairedis#1112)
* da26ace Run 20 vs tests at a time. (sonic-net/sonic-sairedis#1111)
* ffc4109 [asan] suppress the static variable leaks (sonic-net/sonic-sairedis#1085)
* bfd37e3 [sonic-sairedis] Support bulk counter (sonic-net/sonic-sairedis#1094)
* 90ba09a Transfer organization from Azure to sonic-net (sonic-net/sonic-sairedis#1095)
* 4853881 [BFN] Provide unified approach to select P4 profile based on chip family (sonic-net/sonic-sairedis#1089)
@yxieca
Copy link
Contributor

yxieca commented Sep 8, 2022

@Pterosaur there is conflict. Can you raise separate PR or suggesting dependencies?

Pterosaur added a commit to Pterosaur/sonic-sairedis that referenced this pull request Sep 9, 2022
Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed

Signed-off-by: Ze Gan <[email protected]>
Pterosaur added a commit to Pterosaur/sonic-sairedis that referenced this pull request Sep 9, 2022
Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed

Signed-off-by: Ze Gan <[email protected]>
@Pterosaur
Copy link
Contributor Author

@Pterosaur there is conflict. Can you raise separate PR or suggesting dependencies?

Create a separate PR for 202205.

Pterosaur added a commit that referenced this pull request Sep 16, 2022
Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed

Fixing the PR(#1107) conflict with 202205

Signed-off-by: Ze Gan <[email protected]>
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed
skbarista pushed a commit to skbarista/sonic-sairedis that referenced this pull request Dec 2, 2022
Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed

Fixing the PR(sonic-net#1107) conflict with 202205

Signed-off-by: Ze Gan <[email protected]>
@Pterosaur Pterosaur deleted the oper_speed_in_vslib branch January 12, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants