[ycabled] add some exception catching logic to some vendor specific API's #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API's Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
|
What is this fix for? Is it for the "toggles fail while probes work" issue? Can you please provide more details? |
zjswhhh
reviewed
Sep 29, 2022
This PR just adds some exception logic for API's that were not covered, but mostly it wont fix the |
zjswhhh
approved these changes
Sep 29, 2022
Hi @vdahiya12 - One more question, will this re-read writes the response to DBs? |
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 30, 2022
…PI's (#301) This PR adds a try/catch block for some abstract muxcable API's. In particular the exception logic is added for all the API's where there is a possibility for exceptions to be passed by Vendor API's implementation, in this regard ycabled will have all abstract muxcable API's covered by exception logic with this PR. If the exception is caught it will be just logged and daemon will resume its normal operation. Description Motivation and Context How Has This Been Tested? Unit-tests and deploying changes on testbed Signed-off-by: vaibhav-dahiya <[email protected]>
7 tasks
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Feb 9, 2023
…PI's (#301) This PR adds a try/catch block for some abstract muxcable API's. In particular the exception logic is added for all the API's where there is a possibility for exceptions to be passed by Vendor API's implementation, in this regard ycabled will have all abstract muxcable API's covered by exception logic with this PR. If the exception is caught it will be just logged and daemon will resume its normal operation. Description Motivation and Context How Has This Been Tested? Unit-tests and deploying changes on testbed Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya [email protected]
This PR adds a try/catch block for some abstract muxcable API's. In particular the exception logic is added for all the API's where there is a possibility for exceptions to be passed by Vendor API's implementation, in this regard ycabled will have all abstract muxcable API's covered by exception logic with this PR.
If the exception is caught it will be just logged and daemon will resume its normal operation.
Description
Motivation and Context
How Has This Been Tested?
Unit-tests and deploying changes on testbed
Additional Information (Optional)