Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thermalctld] Update line card thermal sensor status to DB #211

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Aug 11, 2021

Update line card thermal sensor status to DB, includes PSU thermal sensors and SFP thermal sensors on line card. Depends on sonic-net/sonic-buildimage#8422.

Description

In thermal update function, update PSU, SFP and direct thermal of line card

Motivation and Context

To support modular chassis

How Has This Been Tested?

  1. Full platform regression, 100% passed
  2. Unit test passed

Additional Information (Optional)

@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2021

This pull request introduces 1 alert when merging 2bd6911 into f63fc94 - view on LGTM.com

new alerts:

  • 1 for Unused import

keboliu
keboliu previously approved these changes Aug 11, 2021
@liat-grozovik
Copy link
Collaborator

@keboliu please review

@liat-grozovik
Copy link
Collaborator

@lguohan please assign someone to review

@sujinmkang sujinmkang requested a review from vdahiya12 August 27, 2021 18:19
@dprital
Copy link
Collaborator

dprital commented Sep 1, 2021

@vdahiya12 - Can you please review ?

@liat-grozovik
Copy link
Collaborator

@vdahiya12 and @keboliu could you please both approve so we can merge?

@qiluo-msft qiluo-msft merged commit 1565a23 into sonic-net:master Oct 18, 2021
@Junchao-Mellanox Junchao-Mellanox deleted the sn4800-thermalctld branch October 21, 2021 01:40
vdahiya12 added a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
….credo as a package (sonic-net#211)

Signed-off-by: vaibhav-dahiya <[email protected]>
Curreently the way python wheel includes packages is all the subdirectories inside a package need to be also included
for them to be a package. Since in the refactor for multiple vendor Y-Cable xcvrd calls these vendor specific modules by including their name which it obtains by reading the eeprom it is required to include them inside setup.py for the wheel to know it has a package.

Signed-off-by: vaibhav-dahiya [email protected]

Description
add the definition inside setup.py to include sonic_y_cabe.credo as a package

Motivation and Context
This is required by all calling API's for vendor agnostic Y-Cable API's to be called for credo specific cables.

How Has This Been Tested?
Built an image and validated the presence of the pacakge.
Ran the API's on a Arista7050cx3 switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants