-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thermalctld] Update line card thermal sensor status to DB #211
Merged
qiluo-msft
merged 2 commits into
sonic-net:master
from
Junchao-Mellanox:sn4800-thermalctld
Oct 18, 2021
Merged
[thermalctld] Update line card thermal sensor status to DB #211
qiluo-msft
merged 2 commits into
sonic-net:master
from
Junchao-Mellanox:sn4800-thermalctld
Oct 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging 2bd6911 into f63fc94 - view on LGTM.com new alerts:
|
keboliu
previously approved these changes
Aug 11, 2021
@keboliu please review |
@lguohan please assign someone to review |
sujinmkang
approved these changes
Aug 27, 2021
@vdahiya12 - Can you please review ? |
@vdahiya12 and @keboliu could you please both approve so we can merge? |
keboliu
approved these changes
Sep 14, 2021
vdahiya12
added a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
….credo as a package (sonic-net#211) Signed-off-by: vaibhav-dahiya <[email protected]> Curreently the way python wheel includes packages is all the subdirectories inside a package need to be also included for them to be a package. Since in the refactor for multiple vendor Y-Cable xcvrd calls these vendor specific modules by including their name which it obtains by reading the eeprom it is required to include them inside setup.py for the wheel to know it has a package. Signed-off-by: vaibhav-dahiya [email protected] Description add the definition inside setup.py to include sonic_y_cabe.credo as a package Motivation and Context This is required by all calling API's for vendor agnostic Y-Cable API's to be called for credo specific cables. How Has This Been Tested? Built an image and validated the presence of the pacakge. Ran the API's on a Arista7050cx3 switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update line card thermal sensor status to DB, includes PSU thermal sensors and SFP thermal sensors on line card. Depends on sonic-net/sonic-buildimage#8422.
Description
In thermal update function, update PSU, SFP and direct thermal of line card
Motivation and Context
To support modular chassis
How Has This Been Tested?
Additional Information (Optional)