[xcvrd] add debug logs for y_cable change events/probes #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
suggested changes
Jun 17, 2021
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
suggested changes
Jun 18, 2021
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
reviewed
Jun 18, 2021
tahmed-dev
reviewed
Jun 18, 2021
|
|
||
| y_cable_platform_sfputil = platform_sfp | ||
| y_cable_platform_chassis = platform_chassis | ||
|
|
||
| fvs_updated = swsscommon.FieldValuePairs([('enable_log', 'false')]) |
There was a problem hiding this comment.
we can go with verbose or log_verbosity in case we are going to have various log verbosity.
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
tahmed-dev
approved these changes
Jun 22, 2021
jleveque
approved these changes
Jun 22, 2021
andywongarista
pushed a commit
to andywongarista/sonic-platform-daemons
that referenced
this pull request
Jun 30, 2021
This PR adds support for logging required in debugging events for change/probe requests received by xcvrd from swss and linkmgr into state DB. a typical log would look like this: Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: trying to enable/disable debug logs Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: received an event for port transition Ethernet4 Jun 17 05:55:39.302575 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: xcvrd trying to transition port Ethernet4 from standby to active Jun 17 05:55:39.307872 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: Successful in toggling mux to ToR A for port 2 where both probe events and change events are logged inside xcvrd. Motivation and Context This is required for xcvrd to log the events which it receives from other modules when we want to see the completion of events as to what triggered the event and at which stage it failed without restarting pmon/xcvrd Signed-off-by: vaibhav-dahiya <[email protected]>
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 7, 2021
This PR adds support for logging required in debugging events for change/probe requests received by xcvrd from swss and linkmgr into state DB. a typical log would look like this: Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: trying to enable/disable debug logs Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: received an event for port transition Ethernet4 Jun 17 05:55:39.302575 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: xcvrd trying to transition port Ethernet4 from standby to active Jun 17 05:55:39.307872 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: Successful in toggling mux to ToR A for port 2 where both probe events and change events are logged inside xcvrd. Motivation and Context This is required for xcvrd to log the events which it receives from other modules when we want to see the completion of events as to what triggered the event and at which stage it failed without restarting pmon/xcvrd Signed-off-by: vaibhav-dahiya <[email protected]>
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…on. (sonic-net#195) Platform vendor can add their own logic to determine the pcie conifiguration revision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya [email protected]
Description
This PR adds support for logging required in debugging events for change/probe requests received by xcvrd from swss and linkmgr into state DB.
a typical log would look like this:
Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: trying to enable/disable debug logsJun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: received an event for port transition Ethernet4Jun 17 05:55:39.302575 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: xcvrd trying to transition port Ethernet4 from standby to activeJun 17 05:55:39.307872 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: Successful in toggling mux to ToR A for port 2where both probe events and change events are logged inside xcvrd.
Motivation and Context
This is required for xcvrd to log the events which it receives from other modules when we want to see the completion of events
as to what triggered the event and at which stage it failed without restarting pmon/xcvrd
How Has This Been Tested?
ran the changes on starlab testbed, by changing the file in the container.
Additional Information (Optional)