-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thermalctld] Use interval set in thermal policy if available #164
Merged
sujinmkang
merged 6 commits into
sonic-net:master
from
andywongarista:master-thermalctld-interval
Aug 6, 2021
Merged
[thermalctld] Use interval set in thermal policy if available #164
sujinmkang
merged 6 commits into
sonic-net:master
from
andywongarista:master-thermalctld-interval
Aug 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix new conflicts |
@Junchao-Mellanox: Please review. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@Junchao-Mellanox: Please review. |
It looks like something went wrong with your latest push. Can you please rebase against the latest master? |
andywongarista
force-pushed
the
master-thermalctld-interval
branch
from
June 30, 2021 22:16
6dfe286
to
20be710
Compare
sujinmkang
approved these changes
Aug 2, 2021
lgtm |
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Configure Azure Pipelines to run unit tests, build Python wheels and publish the test results, test coverage and resulting wheels. Also fix existing unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update thermalctld to retrieve interval from thermal manager (which in turn loads an interval from thermal_policy.json) instead of using a constant.
Motivation and Context
sonic-net/sonic-platform-common#178
This will allow platform vendors to specify an alternate interval for running thermal policies, e.g. 15 seconds instead of the current 60.
How Has This Been Tested?
Verified that thermalctld runs without exiting.
Also ran test_thermalctld.py
Additional Information (Optional)