Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thermalctld] Use interval set in thermal policy if available #164

Merged

Conversation

andywongarista
Copy link
Contributor

Description

Update thermalctld to retrieve interval from thermal manager (which in turn loads an interval from thermal_policy.json) instead of using a constant.

Motivation and Context

sonic-net/sonic-platform-common#178

This will allow platform vendors to specify an alternate interval for running thermal policies, e.g. 15 seconds instead of the current 60.

How Has This Been Tested?

Verified that thermalctld runs without exiting.
Also ran test_thermalctld.py

Additional Information (Optional)

@jleveque
Copy link
Contributor

Please fix new conflicts

@jleveque
Copy link
Contributor

@Junchao-Mellanox: Please review.

@jleveque
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque
Copy link
Contributor

@Junchao-Mellanox: Please review.

@jleveque
Copy link
Contributor

It looks like something went wrong with your latest push. Can you please rebase against the latest master?

@andywongarista andywongarista force-pushed the master-thermalctld-interval branch from 6dfe286 to 20be710 Compare June 30, 2021 22:16
@lguohan lguohan requested review from noaOrMlnx and sujinmkang July 30, 2021 15:32
@sujinmkang
Copy link
Collaborator

lgtm

@sujinmkang sujinmkang merged commit f63fc94 into sonic-net:master Aug 6, 2021
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Configure Azure Pipelines to run unit tests, build Python wheels and publish the test results, test coverage and resulting wheels.

Also fix existing unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants