-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCU] Interface Replace Lanes test to expect op success #5859
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging fc69fe93d6b8769e4e8737a5d39d75a80f90a956 into a7f3015 - view on LGTM.com new alerts:
|
Let's change the test case target config: So it is expected succeed, even we add new enforcement of lane uniqueness. In reply to: 1163555657 Refers to: tests/generic_config_updater/test_eth_interface.py:101 in fc69fe9. [](commit_id = fc69fe93d6b8769e4e8737a5d39d75a80f90a956, deletion_comment = False) |
The Error from logs:
This error was fixed by Sonic-utils was recently updated (2days ago) in sonic-buildimage branch sonic-net/sonic-buildimage#11177 Can we check if |
For replace lanes test, opened new issue sonic-net/sonic-utilities#2263 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
commit 16582f32c14d6b634e17702bb0e0d15250482016 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Thu Jun 23 18:23:41 2022 +0000 add parameter commit 684ee051b91bb9ba1fa9adedef4abcbc8354a5c6 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Thu Jun 23 18:15:45 2022 +0000 lane swap commit fc69fe93d6b8769e4e8737a5d39d75a80f90a956 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Wed Jun 22 19:24:34 2022 +0000 expect success for replaces lanes
16582f3
to
3cef9af
Compare
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Previously, the GCU eth interface replace lanes test expected op failure. However, based on SONiC YANG models, the lanes should be replaced successfully.
The original test passed (expect op failure) because of this issue that has now been fixed by this PR
How did you do it?
Change to expect op success
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation