-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCU] Add rollback validation test #5469
Conversation
"'{}' failed with rc={}".format(cmds, output['rc']) | ||
) | ||
|
||
bgp_listener_pattern = r".*BGPMonitor.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add one sample line as code comment? Suggest to make regex more strict. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking about strict regex, from you sample line, you may use BGPMonitor$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample of stdout: neighbor 11.0.0.1 description BGPMonitor\n neighbor 10.0.0.57 remote-as 64600\n neighbor 10.0.0.57 peer-group PEER_V4\n
Ending character $
will not match.
I change to runningconfig verification. Because some counter such as MsgRcvd
will not be the same after rollback.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
faf801b
to
c681b41
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
Summary: Improve GCU test by adding rollback validation test
[still pending06/01] merge after sonic-net/sonic-utilities#2145
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Cover test gap for GCU rollback
How did you do it?
Record config before test start, then compare if config is the same after rollback.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_bgp*.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation