Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCU] Add rollback validation test #5469

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Apr 6, 2022

Description of PR

Summary: Improve GCU test by adding rollback validation test
[still pending06/01] merge after sonic-net/sonic-utilities#2145
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

Cover test gap for GCU rollback

How did you do it?

Record config before test start, then compare if config is the same after rollback.

How did you verify/test it?

Run test of sonic-mgmt/tests/generic_config_updater/test_bgp*.py on KVM

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587 wen587 requested a review from a team as a code owner April 6, 2022 01:39
"'{}' failed with rc={}".format(cmds, output['rc'])
)

bgp_listener_pattern = r".*BGPMonitor.*"
Copy link
Contributor

@qiluo-msft qiluo-msft Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add one sample line as code comment? Suggest to make regex more strict. #Closed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking about strict regex, from you sample line, you may use BGPMonitor$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample of stdout: neighbor 11.0.0.1 description BGPMonitor\n neighbor 10.0.0.57 remote-as 64600\n neighbor 10.0.0.57 peer-group PEER_V4\n
Ending character $ will not match.
I change to runningconfig verification. Because some counter such as MsgRcvd will not be the same after rollback.

qiluo-msft
qiluo-msft previously approved these changes Apr 7, 2022
@wangxin
Copy link
Collaborator

wangxin commented Apr 30, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Contributor Author

wen587 commented May 31, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Contributor Author

wen587 commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Contributor Author

wen587 commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587 wen587 merged commit 01862c7 into sonic-net:master Jun 16, 2022
wen587 added a commit that referenced this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants