Enhance robustness and add log rotation support for mux simulator #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If topology change is not performed correctly, some open vswitch bridges with "mbr-" prefix may not be completly removed. The mux simulator server is not able to handle those garbage bridges properly and could return error if trying to get mux status of all ports. This change enhanced the mux simualtor to exclude bridges that do not have 3 ports attached to avoid such issue. Some other enhancements: * Add log rotation support. * Add troubleshooting guide in documentation. Signed-off-by: Xin Wang <[email protected]>
yxieca
approved these changes
Feb 18, 2021
|
While this is a good idea to get test going. how can we warn and cleanup these garbage bridges? |
It should not be the mux simulator's responsibility to cleanup garbage bridges. Probably we should record some key information of running test setup in a file on test server after add-topo. The key information should include the topology name. While running remove-topo, firstly check if the topology to be removed matches the recorded running topology. If no, fail early to avoid leaving garbage bridges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
If topology change is not performed correctly, some open vswitch bridges with "mbr-" prefix may not be completely removed. The mux simulator server is not able to handle those garbage bridges properly and could return error if trying to get mux status of all ports.
How did you do it?
This change enhanced the mux simulator to exclude bridges that do not have 3 ports attached to avoid such issue. Some other enhancements:
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation