Fix test_crm_fdb_entry #2701
Merged
Fix test_crm_fdb_entry #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Disable FDB aging 2. Add a loop check after fdbclear Signed-off-by: bingwang <[email protected]>
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
daall
approved these changes
Dec 29, 2020
Comment on lines
+894
to
+900
| while FDB_CLEAR_TIMEOUT > 0: | ||
| # Get new "crm_stats_fdb_entry" used and available counter value | ||
| new_crm_stats_fdb_entry_used, new_crm_stats_fdb_entry_available = get_crm_stats(get_fdb_stats, duthost) | ||
| if new_crm_stats_fdb_entry_used == 0: | ||
| break | ||
| FDB_CLEAR_TIMEOUT -= CRM_POLLING_INTERVAL | ||
| time.sleep(CRM_POLLING_INTERVAL) |
There was a problem hiding this comment.
Can we do a wait_until here instead?
There was a problem hiding this comment.
Good suggestion. I didn't use wait_until because I think the current code is easier to read and understand. Or a new wraper function is needed to check the return value of get_crm_stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
Fixes # (issue)
test_crm_fdb_entrywas consistently failing on TD3. There are 2 reasons for this failure.fdbclearis an asynchronous interface.This PR fix these two issues.
Type of change
Approach
What is the motivation for this PR?
This PR is to fix
test_crm_fdb_entry.How did you do it?
How did you verify/test it?
Verified on 7050cx3
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation