Test case for BFD echo-mode #12642
Test case for BFD echo-mode #12642
Conversation
|
@yxieca Hi Ying, can you please assign a reviewer for this testcase. |
|
|
||
|
|
||
| @pytest.mark.parametrize('ipv6', [False, True], ids=['ipv4', 'ipv6']) | ||
| def test_bfd_echo_mode(request, rand_selected_dut, ptfhost, tbinfo, ipv6): |
There was a problem hiding this comment.
Can you please point to me where the actual BFD session is being created.
From what i understand you are simply setting vtysh -c 'configure terminal' -c 'bfd' -c 'bfd peer {neighbor IP}' -c 'echo-mode'
and then you do
vtysh -c 'show bfd peer'"
Is the intent of the test simply to test i f the echo mode is configurable.
There was a problem hiding this comment.
This command establishes the BFD neighborship first and then enables the echo-mode on the peer. The breakdown of the command is as follows:
-c bfd (to instantiate the bfd instance)
-c bfd peer (neighbor IP)
These two commands create the bfd session.
-c echo-mode (enabling echo-mode on the peer)
This command is to configure the peer.
Refer to lines 326-328 in bfd_test.py.
| assert error is False | ||
| finally: | ||
| # Cleanup: Remove BFD sessions and echo mode configurations | ||
| remove_bfd_sessions(duthost, neighbor_addrs) |
There was a problem hiding this comment.
if no sessions are created why the cleanup.
There was a problem hiding this comment.
BFD sessions are being created first as mentioned in the previous comment. So, cleanup is required for session tear-down.
|
@siqbal1986 Hi, Can you please help expedite this test-case. Target is 202405 release. Thanks in advance. |
|
@yxieca can you pls help merge this testcase. |
|
@Ghulam-Bahoo @siqbal1986 This test uses FRR based bfd and not BFD offload. However for FRR based BFD we need to have frr_mgmt_framework_config set to true I don't see this test case explicitly introducing this configuration. How does this test work? We see the following error @nhe-NV FYI |
|
@Ghulam-Bahoo Can you please help check? |
|
@Ghulam-Bahoo @ridahanif96 Can you please address the issue in this test as mentioned in an earlier comment. This test has been failing from day one. the other choice is to revert this PR. |
This reverts commit ffae98d.
Description of PR
Summary:
This PR introduces a new test case in the existing BFD test plan focused on testing the existing BFD echo-mode feature. By testing BFD echo-mode functionality, I aim to ensure its reliability and effectiveness in real-world scenarios.
Type of change
Approach
What is the motivation for this PR?
Enabling BFD Echo-mode provides an additional layer of fault detection in network environments. This proactive approach helps to minimize network downtime and improve overall network reliability.
How did you do it?
Enabling BFD echo-mode across all neighbors in the topology.
How did you verify/test it?
I verified the test by running the command:
which will show all the details about bfd neighbors.