[action] [PR:11180] [SNMP]: Modify test to verify all queue indexes are present #11308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#11180) ## Approach #### What is the motivation for this PR? ADO : 26336010 Modify test to detect issue sonic-net/sonic-buildimage#17448. #### How did you do it? Currently test_snmp_queue only verifies that each interface does have queue counters associated with it. It does not verify if all the expected queue counters are present. Modify test_snmp_queue to add 2 additional checks: 1. Ensure that queue index with queue configuration in config_db, is present for each interface. 2. Ensure that the number of Unicast queue counters for each interface in 'show queue counters <interface name> is the same as the number of queue indexes in the SNMP result. #### How did you verify/test it? Test case passes for single-asic/multi-asic/Chassis platforms. Test case passed with: 202205/202305/202311/master images Test case fails when run on device with image which has the issue: sonic-net/sonic-buildimage#17448. ``` snmp_q_idx = int(queue_idx) + 1 if str(snmp_q_idx) not in v['queues'][direction_type]: pytest.fail("\ Expected queue index %d not present in SNMP \ > result for interface %s" % (snmp_q_idx, v['name'])) E Failed: Expected queue index 6 not present in SNMP result for interface Ethernet13/3 .. snmp/test_snmp_queue.py:87: Failed -------------------------------------------------------------------------------------------------- generated xml file: /data/sonic-mgmt-int/tests/logs/tr.xml -------------------------------------------------------------------------------------------------- =================================================================================================================== short test summary info ==================================================================================================================== FAILED snmp/test_snmp_queue.py::test_snmp_queues[str3-7060-acs-1] - Failed: Expected queue index 6 not present in SNMP result for interface Ethernet13/3 ================================================================================================================== 1 failed in 248.30 seconds ================================================================================================================== INFO:root:Can not get Allure report URL. Please check logs ```
7 tasks
|
Original PR: #11180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
ADO : 26336010
Modify test to detect issue sonic-net/sonic-buildimage#17448.
How did you do it?
Currently test_snmp_queue only verifies that each interface does have queue counters associated with it.
It does not verify if all the expected queue counters are present.
Modify test_snmp_queue to add 2 additional checks:
How did you verify/test it?
Test case passes for single-asic/multi-asic/Chassis platforms.
Test case passed with: 202205/202305/202311/master images
Test case fails when run on device with image which has the issue: sonic-net/sonic-buildimage#17448.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation