-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure for test_passw_hardening #6428
Comments
@davidpil2002 Could you please take a look? |
sure, |
6 tasks
ZhaohuiS
added a commit
that referenced
this issue
Sep 29, 2022
What is the motivation for this PR? test_passw_hardening is unable to run on master image because sonic-net/sonic-buildimage#12138 hasn't been merged. But after running it on 202205 image which supports passw-harden(enabled in this PR sonic-net/sonic-buildimage#12025), found an issue and raised here #6428. I think that it's better to skip test case in tests_mark_conditions.yaml instead of in test script. How did you do it? Move skip condition to tests_mark_conditions.yaml Add an issue in skip condition. After it's been fixed, we can run this script. How did you verify/test it? Run passw_hardening/test_passw_hardening.py Signed-off-by: Zhaohui Sun <[email protected]>
6 tasks
ZhaohuiS
added a commit
that referenced
this issue
Oct 9, 2022
What is the motivation for this PR? passw_hardening/test_passw_hardening.py should be ran on master image and with issue #6428 fixed. Currently, issue #6428 is not fixed, the defulat logical operator is AND, so for master image, the final result is False, the case is not skipped. How did you do it? Change condition_logical_operator to OR, if the issue is fixed, it will run on master image, otherwise it will be skipped for all images. Signed-off-by: Zhaohui Sun <[email protected]>
ZhaohuiS
pushed a commit
that referenced
this issue
Oct 16, 2022
What is the motivation for this PR? Fix the issue #6428 How did you do it? explained in the summary. How did you verify/test it? Run the test with the sonic-builimage build from branch 202205 command line: py.test /sonic-mgmt/tests/passw_hardening/test_passw_hardening.py
Fixed in #6453 |
wangxin
pushed a commit
that referenced
this issue
Oct 17, 2022
What is the motivation for this PR? Fix the issue #6428 How did you do it? explained in the summary. How did you verify/test it? Run the test with the sonic-builimage build from branch 202205 command line: py.test /sonic-mgmt/tests/passw_hardening/test_passw_hardening.py
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this issue
Oct 17, 2022
) What is the motivation for this PR? test_passw_hardening is unable to run on master image because sonic-net/sonic-buildimage#12138 hasn't been merged. But after running it on 202205 image which supports passw-harden(enabled in this PR sonic-net/sonic-buildimage#12025), found an issue and raised here sonic-net#6428. I think that it's better to skip test case in tests_mark_conditions.yaml instead of in test script. How did you do it? Move skip condition to tests_mark_conditions.yaml Add an issue in skip condition. After it's been fixed, we can run this script. How did you verify/test it? Run passw_hardening/test_passw_hardening.py Signed-off-by: Zhaohui Sun <[email protected]>
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this issue
Oct 17, 2022
…net#6482) What is the motivation for this PR? passw_hardening/test_passw_hardening.py should be ran on master image and with issue sonic-net#6428 fixed. Currently, issue sonic-net#6428 is not fixed, the defulat logical operator is AND, so for master image, the final result is False, the case is not skipped. How did you do it? Change condition_logical_operator to OR, if the issue is fixed, it will run on master image, otherwise it will be skipped for all images. Signed-off-by: Zhaohui Sun <[email protected]>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this issue
Oct 28, 2022
) What is the motivation for this PR? test_passw_hardening is unable to run on master image because sonic-net/sonic-buildimage#12138 hasn't been merged. But after running it on 202205 image which supports passw-harden(enabled in this PR sonic-net/sonic-buildimage#12025), found an issue and raised here sonic-net#6428. I think that it's better to skip test case in tests_mark_conditions.yaml instead of in test script. How did you do it? Move skip condition to tests_mark_conditions.yaml Add an issue in skip condition. After it's been fixed, we can run this script. How did you verify/test it? Run passw_hardening/test_passw_hardening.py Signed-off-by: Zhaohui Sun <[email protected]>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this issue
Oct 28, 2022
…net#6482) What is the motivation for this PR? passw_hardening/test_passw_hardening.py should be ran on master image and with issue sonic-net#6428 fixed. Currently, issue sonic-net#6428 is not fixed, the defulat logical operator is AND, so for master image, the final result is False, the case is not skipped. How did you do it? Change condition_logical_operator to OR, if the issue is fixed, it will run on master image, otherwise it will be skipped for all images. Signed-off-by: Zhaohui Sun <[email protected]>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this issue
Oct 28, 2022
What is the motivation for this PR? Fix the issue sonic-net#6428 How did you do it? explained in the summary. How did you verify/test it? Run the test with the sonic-builimage build from branch 202205 command line: py.test /sonic-mgmt/tests/passw_hardening/test_passw_hardening.py
6 tasks
wangxin
pushed a commit
that referenced
this issue
Jun 14, 2023
This PR removes the skip of password hardening test, as the issue #6428 is already fixed, and the test can run on 202205 and 202211 branches. What is the motivation for this PR? Remove the skip for password hardening test as the test can run on any branch (not only master) How did you do it? Removed the skip from test_mark_conditions.py
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this issue
Oct 3, 2023
This PR removes the skip of password hardening test, as the issue sonic-net#6428 is already fixed, and the test can run on 202205 and 202211 branches. What is the motivation for this PR? Remove the skip for password hardening test as the test can run on any branch (not only master) How did you do it? Removed the skip from test_mark_conditions.py
AharonMalkin
added a commit
to AharonMalkin/sonic-mgmt
that referenced
this issue
Jan 25, 2024
This PR removes the skip of password hardening test, as the issue sonic-net#6428 is already fixed, and the test can run on 202205 and 202211 branches. What is the motivation for this PR? Remove the skip for password hardening test as the test can run on any branch (not only master) How did you do it? Removed the skip from test_mark_conditions.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
test_passw_hardening
failed because of these parameters in the casetest_passw_hardening_history
It defines expiration=0 and expiration_warning=0 in case test_passw_hardening_history, but in yang module, it starts from 1, not from 0. That's why the command doesn't work. Please see the error message as below.
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-passwh.yang#:~:text=type%20uint16%20%7B-,range%201..365%3B,-%7D
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Additional information you deem important:
The text was updated successfully, but these errors were encountered: