Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for OC YANG interfaces. #124

Closed
wants to merge 33 commits into from

Conversation

nagarwal03
Copy link
Contributor

@nagarwal03 nagarwal03 commented Mar 6, 2024

What we did:
Added transformer support for OpenConfig Interfaces as specified in the HLD

Why we did it?
Earlier, intf_app.go was used for interfaces configuration. Replacing it with xfmr_intf.go to add transformer support for OpenConfig YANG interfaces configuration via REST and gNMI.

How did we verify the changes?
Verified by adding unit test files for REST and gNMI.

Unit test file changes:

  1. interfaces_openconfig_test.go – To test the parameters in the openconfig-interfaces.yang via REST.
    testapp.log
  2. gNMI is tested manually.

Log files for REST manual run:
REST_ETHERNET.log
REST_SUBINTERFACE.log
REST_TOP.log

Log files for gNMI manual run:
GNMI_ETH.log
GNMI_SUB.log
GNMI_TOP.log

Translib.test Logs:
translib.test log

Support added:

  1. Provide support for OpenConfig Interfaces YANG models.
  2. Replace translib App based implementation with a Transformer based implementation of:
    • Get Ethernet interface attributes.
    • Configure/ Set Ethernet interface attributes.
    • Delete Ethernet interface attributes.
  3. Ethernet interface parameters can be modified via REST and gNMI.
  4. Support port-speed and auto-negotiation on Ethernet interfaces via REST and gNMI.
  5. Support IPv4 and IPv6 address configuration on Ethernet interfaces via REST and gNMI.
  6. This does not cover gNMI subscription. This is planned for the next phase.

Satoru-Shinohara and others added 30 commits January 30, 2024 15:44
…f github.com:nagarwal03/oc-yang-intf into Nikita_subintf_oc_yang
Adding support for OC yang interfaces.
Remove IntfType related code for any non-supported types
Code Clean-up - Remove unsupported interface related code
Merge branch 'oc-intf-common-code-Jan30' into Nikita_subintf_oc_yang
Adding automation file for subinterfaces.
Add Interface-level and Ethernet UT scripts + Merge all interface related tests to 1 file
Addressing review comments. Removed family attribute from OC Yang.
Updating automation files. Removed family attribute.
Adding fixes based on review. Adding go.mod and go.sum files for tran…
Address additional review comments regarding port-speed and switch ca…
Adding support for OC YANG interfaces.
Copy link

linux-foundation-easycla bot commented Mar 6, 2024

CLA Missing ID CLA Not Signed

@nagarwal03 nagarwal03 closed this Mar 8, 2024
@nagarwal03 nagarwal03 deleted the internal-review-ocintf branch March 8, 2024 00:06
@Satoru-Shinohara Satoru-Shinohara restored the internal-review-ocintf branch March 8, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants