Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox][SAISERVER] Support Mellanox saiserverv1 and saiserverv2 docker #9686

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

RyoYang
Copy link
Contributor

@RyoYang RyoYang commented Jan 6, 2022

add saiserver into buster and revert some changes

Why I did it

support mlnx saiserverv1 and saiserverv2

How I did it

Support saiserver v2 with python3 and thrift 0.14.0
add variables to support the saiserverv2
build different thrift in saithrift depends on saiserver version
build differernt versions of saiserver
make the saiserver and saiserver docker with version number

How to verify it

build two different versions of sasiserver in local build environment
todo: test on devices

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

add saiserver into buster and revert some changes

remove unused part
@RyoYang RyoYang force-pushed the mlnx_saiserverv2_support branch from a4ae45c to 0bce3be Compare January 6, 2022 10:34
@RyoYang RyoYang changed the title [mlnx][saiserver]support saiserverv1 and saiserverv2 docker [Mellanox][SAISERVER] Support Mellanox saiserverv1 and saiserverv2 docker Jan 7, 2022
richardyu-ms
richardyu-ms previously approved these changes Jan 9, 2022
Copy link
Contributor

@richardyu-ms richardyu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait for other reviews

@RyoYang RyoYang merged commit c8db7a2 into sonic-net:master Mar 10, 2022
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

@liat-grozovik
Copy link
Collaborator

@RyoYang will you be able to have a PR against 202012 soon?

RyoYang added a commit to RyoYang/sonic-buildimage that referenced this pull request Apr 4, 2022
…cker (sonic-net#9686)

* support saiserverv1 and saiserverv2 docker

* add saiserver into buster and revert some changes

* update thrift version
RyoYang added a commit to RyoYang/sonic-buildimage that referenced this pull request Apr 4, 2022
…cker (sonic-net#9686)

* support saiserverv1 and saiserverv2 docker

* add saiserver into buster and revert some changes

* update thrift version
@RyoYang
Copy link
Contributor Author

RyoYang commented Apr 4, 2022

@RyoYang will you be able to have a PR against 202012 soon?

@liat-grozovik PR cherry-picked to 202012 branch has done, please have a look #10459
As 202012 branch's mlnx-saiserverv2 has not been verified on DUT, we may not check-in the code in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants