[Mellanox] [systemd] Increase syncd startup script timeout to complete ASIC FW update #6709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on init. Signed-off-by: liora <[email protected]>
|
@lguohan Appreciate your review. |
liat-grozovik
changed the title
|
@liorghub this fix is pending a submodule update, please refer to which sai-redis change this is pending so it will not be merged before. |
|
@liat-grozovik |
thanks. Please check build failure. |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 6709 in repo Azure/sonic-buildimage |
|
retest this please |
|
retest kvmtest-t0 |
|
retest Test kvmtest-t0 |
|
@liat-grozovik Log shows bgp test is failing, for sure not related to my changes. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Feb 10, 2021
liat-grozovik
changed the title
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
… on init. (#6709) **- Why I did it** To support FW upgrade on init. **- How I did it** Change timeout value **- How to verify it** I manually changed ASIC and Gearbox FW followed by hard reset in order for FW upgrade to take place on init. Signed-off-by: liora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[systemd] Increase syncd startup script timeout to support FW upgrade on init (Mellanox only).
Add prints to syslog in syncd startup script to indicate FW upgrade is in progress.
This change should be merged after the following PRs were merged:
sonic-net/sonic-sairedis#774 (master)
sonic-net/sonic-sairedis#776 (201911)
There is no PR for 201912 yet (I will make sure to add one).
Signed-off-by: liora [email protected]
- Why I did it
To support FW upgrade on init.
- How I did it
Change timeout value
- How to verify it
I manually changed ASIC and Gearbox FW followed by hard reset in order for FW upgrade to take place on init.
- Which release branch to backport (provide reason below if selected)