Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcie-check] Fix incorrect subcommand of pcieutil in pcie-check.sh #6677

Closed
wants to merge 1 commit into from

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Feb 4, 2021

Signed-off-by: bingwang [email protected]

- Why I did it
Fix #6676
PR #1297 removes redundant 'pcie-' prefix from subcommands. However, pcie-check.sh script is not updated yet. So errors are reported.

 3253 Feb  3 23:07:17.736780 str-7260cx3-acs-2 INFO pcie-check.sh[1001]: Usage: pcieutil [OPTIONS] COMMAND [ARGS]...                                                                                   
 3254 Feb  3 23:07:17.736922 str-7260cx3-acs-2 INFO pcie-check.sh[1001]: Try "pcieutil --help" for help.
 3255 Feb  3 23:07:17.737276 str-7260cx3-acs-2 INFO pcie-check.sh[1001]: Error: No such command "pcie-check".

- How I did it
Fix incorrect subcommand. pcie-check -> check.

- How to verify it
Verified on A7260. No errors are seen, and pcie-check passed.

Feb  4 02:33:43.626555 str-7260cx3-acs-2 NOTICE admin: /usr/bin/pcie-check.sh : PCIe check passed

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

Fix incorrect subcommand of pcieutil in pcie-check.sh

- A picture of a cute animal (not mandatory but encouraged)

@bingwang-ms bingwang-ms requested a review from lguohan as a code owner February 4, 2021 02:38
@lguohan
Copy link
Collaborator

lguohan commented Feb 4, 2021

which pr fix?

PR #1297 removes redundant 'pcie-' prefix from subcommands. However, pcie-check.sh script is not updated yet. So errors are reported.

@bingwang-ms
Copy link
Contributor Author

which pr fix?

PR #1297 removes redundant 'pcie-' prefix from subcommands. However, pcie-check.sh script is not updated yet. So errors are reported.

This PR addressed the issue by updating pcie-check.sh.

@bingwang-ms
Copy link
Contributor Author

duplicated with #6682

@bingwang-ms bingwang-ms closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pcie-check.sh] Incorrect command in pcie-check.sh
2 participants