-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minigraph.py to parse kubernetes config from minigraph.xml #6633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om DeviceMetadata section.
renukamanavalan
requested review from
lguohan,
qiluo-msft,
judyjoseph and
isabelmsft
February 1, 2021 17:25
kcudnik
previously approved these changes
Feb 1, 2021
qiluo-msft
reviewed
Feb 2, 2021
qiluo-msft
reviewed
Feb 2, 2021
qiluo-msft
reviewed
Feb 2, 2021
qiluo-msft
reviewed
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor format issue. Otherwise lgtm.
No logical code changes.
qiluo-msft
approved these changes
Feb 2, 2021
deran1980
pushed a commit
to deran1980/sonic-buildimage
that referenced
this pull request
Feb 4, 2021
…nic-net#6633) Update minigraph parser to retrieve kubernetes server info from minigraph.xml and update "KUBERNETES_MASTER|SERVER" in running config. Update minigraph parser to include clusterName from minigraph.xml into "DEVICE_METADATA|localhost"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To make the kubernetes server IP & enabled/disabled status configurable through minigraph.
Saved cluster name into "DEVICE_METADATA|localhost" , so this can be available for kubernetes use.
- How I did it
Updated the parser (minigraph.py) to get it from MetadataDeclaration/Devices/DeviceMetadata section for this device.
Add to "DEVICE_METADATA|localhost" , if ClusterName is available in PngDec/Devices/Device for localhost
- How to verify it
Unit test is added to parse & test out.
For manual test add the following to MetadataDeclaration/Devices/DeviceMetadata section. call "config load_minigraph" and verify through "show kube server config"
Look for "DEVICE_METADATA": { "localhost": { ... "cluster": "<this device cluster name", ...}}, if minigraph.xml does carry it in JSON dump or /etc/sonic/config_db.json
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)