Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Update FW upgrade script to use 'mlxfwmanager -d' option for specifying MST device in FW burn operation #6541

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

liorghub
Copy link
Contributor

@liorghub liorghub commented Jan 24, 2021

- Why I did it
Reduce the time it takes for the ASIC FW burn as part of the automatic FW upgrade procedure.

- How I did it
Add -d option to mlxfwmanager tool to use the faster MST device and not the default one which is not the fastest one.

- How to verify it
I manually changed ASIC FW followed by reboot command in order for FW upgrade to take place on deinit.
I manually changed ASIC FW followed by hard reset in order for FW upgrade to take place on init.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

@lguohan lguohan requested a review from sujinmkang January 25, 2021 00:29
@sujinmkang
Copy link
Collaborator

@liorghub was there any problem to choose MST device without this change?

@liorghub
Copy link
Contributor Author

@liorghub was there any problem to choose MST device without this change?

The path to MST device is not the same in all systems.
It is the same per ASIC type, hence this change.

@liat-grozovik liat-grozovik changed the title [Mellanox] Change FW upgrade script to use 'mlxfwmanager -d' option for specifying MST device in FW burn operation. [Mellanox] Update FW upgrade script to use 'mlxfwmanager -d' option for specifying MST device in FW burn operation Jan 26, 2021
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section how it was tested for both sonic to sonic upgrade (via the different reboots)

platform/mellanox/mlnx-fw-upgrade.j2 Outdated Show resolved Hide resolved
@liorghub
Copy link
Contributor Author

Please add a section how it was tested for both sonic to sonic upgrade (via the different reboots)

Added.

@liorghub liorghub closed this Jan 31, 2021
@liorghub liorghub reopened this Jan 31, 2021
@liorghub liorghub requested a review from a team as a code owner February 1, 2021 06:37
@ghost
Copy link

ghost commented Feb 1, 2021

CLA assistant check
All CLA requirements met.

@liorghub
Copy link
Contributor Author

liorghub commented Feb 1, 2021

@sujinmkang Appreciate your review.

@liat-grozovik liat-grozovik removed the request for review from a team February 1, 2021 08:22
nazariig
nazariig previously approved these changes Feb 2, 2021
sujinmkang
sujinmkang previously approved these changes Feb 3, 2021
@liorghub liorghub dismissed stale reviews from sujinmkang and nazariig via 37f96ec February 3, 2021 08:10
@liorghub liorghub requested a review from lguohan as a code owner February 3, 2021 08:10
@liat-grozovik
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit f76926a into sonic-net:master Feb 4, 2021
@liat-grozovik
Copy link
Collaborator

@abdosi suggest to include in 201911. Please approve and add the relevant label.

daall pushed a commit that referenced this pull request Feb 5, 2021
…or specifying MST device in FW burn operation (#6541)

**- Why I did it**
Reduce the time it takes for the ASIC FW burn as part of the automatic FW upgrade procedure.

**- How I did it**
Add -d option to mlxfwmanager tool to use the faster MST device and not the default one which is not the fastest one.

**- How to verify it**
I manually changed ASIC FW followed by reboot command in order for FW upgrade to take place on deinit.
I manually changed ASIC FW followed by hard reset in order for FW upgrade to take place on init.

Signed-off-by: liora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants