[sonic-sairedis] submodule update

[Sabareesh-Kumar-Anandan]

[vs] Add workaround for clean up macsec ports (#752)
[SAI submodule] Update SAI to 1.7.1 (#748)
[logfile]: Add handling of Sairedis rec filename (#747)
Update README.md
[meta] Fix stat_mode enums to sai_bulk_op_error_mode_t (#753)
[syncd][tests] Add syncd deprecated attribute value test (#751)
[vs] Skip MACsec clean up if /sbin/ip is not accessible (#750)
Configure enable -Wcast-align=strict when supported by compiler (#749)
[syncd] Translate depreacated attr enum values to new ones (#746)
[sairedis]vs SAI support for voq neighbor (#725)
[syncd] Translate removed RIDs in fdb notification (#734)
[syncd] Move syncd classes to syncd namespace (#742)
[vs] Use /sbin/ip absolute path for ip command in MACsecManager (#744)
[saidiscovery] Update saidiscovery to use VendorSai object and metadata (#736)
Remove Winline warning since it depends on external headers (#741)
[meta] Enable strict cast-align warning (#738)
[vs] Use meta class instead info when using unittests (#740)
[vs] Support flush entry type all on virtual switch (#735)
[vslib]: Add MACsec state to state base (#722)
[README.md] Update installation steps (#730)
Switch Capability support (#728)
[vs] Fail switch create when warm boot requested and no warm boot state (#739)
Dynamic Port breakout fix the crash, port down event processing after<80> (#727)
Code clean (#721)

Signed-off-by: Sabareesh Kumar Anandan [email protected]

- Why I did it

- How I did it

- How to verify it

- Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[lguohan]

@kcudnik , build failure. can you check? https://sonic-jenkins.westus2.cloudapp.azure.com/job/broadcom/job/buildimage-brcm-all-pr/6611/console

[kcudnik]

g++: error: unrecognized command line option '-Wcast-align=strict'; did you mean '-Wcast-align'?
seems like gcc that compiles broadcom and mellanox dont have this strict align option

and mellanox:
C++ exception with description ":- cleanup_macsec_device: Cannot show MACsec ports" thrown in SetUp().
this is by macsec issue

[kcudnik]

i will make fix PR for mellanox (broadcom will also fail after cast fix)

[lguohan]

broadcom build failure depends on this PR. #6106

[kcudnik]

@Sabareesh-Kumar-Anandan you will need to move sairedis pointer forward, after fix on sairedis will be merged, and also maybe wait for update on brcm PR fix

[kcudnik]

mellanox fix PR merged on sairedis

[Sabareesh-Kumar-Anandan]

Thanks @kcudnik. I have updated the sairedis pointer

[kcudnik]

hmm, mellanox still failing in the same error
C++ exception with description ":- cleanup_macsec_device: Cannot show MACsec ports" thrown in SetUp().
maybe there is no /sbin/ip in that build docker but this would seem unlikely, i can add another check in code for that and skip if not command is found, but it would be better to figure out is this command is there

@lguohan does meallanox docker is build in some special way ?

[lguohan]

this is running inside the sonic-slave docker, it is the same for broadcom, mellanox.

[lguohan]

@kcudnik, can you investigate more on the build issue? we have lots of new sairedis pr to merge.

[kcudnik]

retest vsimage please

[kcudnik]

I added cast-align=strict condition sonic-net/sonic-sairedis#749
And here is temporary fix for ip command: sonic-net/sonic-sairedis#750

After those 2 will be checked in then we can move forward sairedis pointer and then it should pass the builds

[lguohan]

both pr mentioned by kamil is merged, wonder if you can update this submodule update so that we can get this one merge?

[kcudnik]

still the same error :(
C++ exception with description ":- cleanup_macsec_device: Cannot show MACsec ports" thrown in SetUp().
have no idea how to debug this one

since this is failing in the same way, then my guess is that, /sbin/ip command is there but it doesn't support "macsec" option and ip exits with non zero status which causes to throw exception
/sbin/ip macsec show https://github.com/Azure/sonic-sairedis/blob/master/vslib/src/MACsecManager.cpp#L848

code belongs to @Pterosaur, which i believe is on vacation now, and it would be better to actually use programmatic way to obtain macsec information instead of using shell commands, since if there are no macsec headers in the build docker we would know this at compilation stage

i can make another workaround for this to disable it completely, since i don't believe we are using macsec anywhere

i added one more fix: sonic-net/sonic-sairedis#752
you can try advance pointer after that, and if it will not work, i will reverse all macsec PRs from sonic-sairedis, i wanted to avoid that since it will be hell, there are like 5 PR's for that and they are on top of each other

[kcudnik]

intresting mellanox passed without macsec fix

@Sabareesh-Kumar-Anandan i merged fix in sairedis repo, lets try one last time to update this submodule pointer

please don't include top "CPU queues on vslib" commit on sairedisrepo

[lguohan]

test passing. https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8018/

[lguohan]

test passing. https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8018/

[lguohan]

test passing. https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8018/