Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPB] [Mellanox] added capability files for SN3700 platform #6021

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Nov 24, 2020

- Why I did it

platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout

- How I did it

Created capability files according to platform specification SN3700

- How to verify it

Full qualification requires bugs fixes reported under sonic-buildimage

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if we can allow all other speeds when all lanes are used and no split.
like 1x200G[100G, 40G] can we add more options?

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing 50g in the default, any reason why not?

@vadymhlushko-mlnx
Copy link
Contributor Author

please check if we can allow all other speeds when all lanes are used and no split.
like 1x200G[100G, 40G] can we add more options?

If I will try split mode like this - 1x200G[100G,50G,40G,25G,10G], I will get the next error:

libyang[0]: Value "1x200G[100G,50G,40G,25G,10G]" does not satisfy the constraint "1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G" (range, length, or pattern). (path: /sonic-breakout_cfg:sonic-breakout_cfg/BREAKOUT_CFG/BREAKOUT_CFG_LIST[port='Ethernet252']/brkout_mode)
Data Loading Failed
Failed to break out Port. Error: Failed to load the config. Error: ConfigMgmtDPB Class creation failed

But 1x200G[100G,50G,40G,25G,10G] seems to be a valid mode, I will ask the owners about it.

@vadymhlushko-mlnx
Copy link
Contributor Author

retest vsimage please

@vadymhlushko-mlnx
Copy link
Contributor Author

Please don't merge this PR until [DPB][MLNX][YANG-models] extended regex pattern according to MLNX systems speeds requirements PR will be merged

@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as ready for review December 23, 2020 12:59
@liat-grozovik
Copy link
Collaborator

retest vsimage please

1 similar comment
@vadymhlushko-mlnx
Copy link
Contributor Author

retest vsimage please

@vadymhlushko-mlnx
Copy link
Contributor Author

retest vsimage please

@liat-grozovik liat-grozovik changed the title [DPB] added capability files for SN3700 platform [DPB] [Mellanox] added capability files for SN3700 platform Jan 13, 2021
@liat-grozovik liat-grozovik merged commit dd13e41 into sonic-net:master Jan 17, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx deleted the sn3700_dpb_capability_files branch January 18, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants