[config/acl] Support everflow config translation #468

taoyl-ms · 2017-04-01T02:08:23Z

No description provided.

lguohan · 2017-04-06T17:36:26Z

src/sonic-config-engine/minigraph.py

@@ -218,9 +218,10 @@ def parse_dpg(dpg, hname):
        aclintfs = child.find(str(QName(ns, "AclInterfaces")))
        acls = {}
        for aclintf in aclintfs.findall(str(QName(ns, "AclInterface"))):
-            aclname = aclintf.find(str(QName(ns, "InAcl"))).text
+            aclname = aclintf.find(str(QName(ns, "InAcl"))).text.lower().replace(" ", "_").replace("-", "_")


what's the reason to change the aclname? #ByDesign

To keep consistency with the name in acl.json #Closed

lguohan · 2017-04-06T17:37:15Z

src/sonic-config-engine/minigraph.py

@@ -229,9 +230,12 @@ def parse_dpg(dpg, hname):
                    print >> sys.stderr, "Warning: ACL " + aclname + " is attached to a Vlan interface, which is currently not supported"
                elif port_alias_map.has_key(member):
                    acl_intfs.append(port_alias_map[member])
+                elif member.lower() == 'erspan':


add comment here? If it is erspan, then attach the acl to all front panel ports. #Resolved

lguohan · 2017-04-06T17:41:27Z

src/sonic-config-engine/translate_acl

-            port = ','.join(attach_to[tablename])
+        if mini_acl.has_key(tablename):
+            is_mirror = mini_acl[tablename]['IsMirror']
+            port = ','.join(mini_acl[tablename]['AttachTo'])


port->ports #Resolved

lguohan

see comments

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915) Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925) Add retryCount option for orchagent_restart_check program. (sonic-net#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874) [intfsorch] Wait for interface prior to prefix (sonic-net#796) Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945) [test]: Fix set interface in configuration database (sonic-net#956) [copporch]: Fix polymorphic type error (sonic-net#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953) [portsorch]: Add reference count of port (sonic-net#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950) remove crm acl_counters when acl_table removed (sonic-net#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) [policerorch]: Fix return code comparison error (sonic-net#968) [gitignore]: Add swss-dbg related files (sonic-net#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934) [vxlanorch]: Add extra info into NOTICE logs (sonic-net#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955) [copporch]: Fix copporch in DEL command (sonic-net#972) [orchagent]: Fix crash during orchagent process exit (sonic-net#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958) [test]: Skip unstable test test_vnet_orch_1 (sonic-net#976) [intfsorch]: Fix rif flex counter removal error (sonic-net#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981) [teamsyncd]: Add information for LAG membership changes (sonic-net#982) common: Add an assert to logger, which will log a message and abort. (sonic-net#286) [test]: Add IpAddress::isZero() unit test (sonic-net#289) do not abort when read timerfd return 0 and errno = 0 (sonic-net#291) Add BGP_STATE_TABLE in stateDB (sonic-net#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285) Add ignore Wshadow pragma to json.hpp (sonic-net#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294) timerfd:read failure - Record in logs as error. (sonic-net#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472) Fixed config_syncd_barefoot function (sonic-net#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480) Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473) Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482) Add TimerWatchdog for monitoring long execution apis (sonic-net#469) Add specific comparison logic for tunnel map (sonic-net#475) [vslib] add ACL action capabilities support (sonic-net#481) Per buffer pool watermark polling mode (sonic-net#485) Add specific comparison logic for ACL counter (sonic-net#484) Process flex counters requests in separate thread (sonic-net#483) Make sairedis/syncd synchronous (sonic-net#476) Fixed conditional operator. (sonic-net#487) Signed-off-by: Shu0T1an ChenG <[email protected]>

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915) Fix typo in orchagent_restart_check from fasle to false. (#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (#925) Add retryCount option for orchagent_restart_check program. (#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (#874) [intfsorch] Wait for interface prior to prefix (#796) Set timer only when interval changes. Not in each firing of the timer. (#945) [test]: Fix set interface in configuration database (#956) [copporch]: Fix polymorphic type error (#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953) [portsorch]: Add reference count of port (#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950) remove crm acl_counters when acl_table removed (#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966) [policerorch]: Fix return code comparison error (#968) [gitignore]: Add swss-dbg related files (#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934) [vxlanorch]: Add extra info into NOTICE logs (#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955) [copporch]: Fix copporch in DEL command (#972) [orchagent]: Fix crash during orchagent process exit (#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958) [test]: Skip unstable test test_vnet_orch_1 (#976) [intfsorch]: Fix rif flex counter removal error (#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981) [teamsyncd]: Add information for LAG membership changes (#982) common: Add an assert to logger, which will log a message and abort. (#286) [test]: Add IpAddress::isZero() unit test (#289) do not abort when read timerfd return 0 and errno = 0 (#291) Add BGP_STATE_TABLE in stateDB (#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (#285) Add ignore Wshadow pragma to json.hpp (#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294) timerfd:read failure - Record in logs as error. (#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472) Fixed config_syncd_barefoot function (#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (#480) Add default bridge id for bridge port id of type PORT in virtual switch (#473) Fix a bug in parsing kernel argument of fast-reboot (#482) Add TimerWatchdog for monitoring long execution apis (#469) Add specific comparison logic for tunnel map (#475) [vslib] add ACL action capabilities support (#481) Per buffer pool watermark polling mode (#485) Add specific comparison logic for ACL counter (#484) Process flex counters requests in separate thread (#483) Make sairedis/syncd synchronous (#476) Fixed conditional operator. (#487) Signed-off-by: Shu0T1an ChenG <[email protected]>

Signed-off-by: Roman Kachur <[email protected]>

…he fec configuration is blank (sonic-net#468)

* ARM32 bit fixes, for 64bit printf format specifier Signed-off-by: Antony Rheneus <[email protected]>

804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (#463) 1e924ac Fix: ConfigDBConnector call super init with proper parameter name (#470) 70e02c8 [azp] Purge swss before installing the newly built deb package (#472) 15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (#468)

*804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (#463) *1e924ac Fix: ConfigDBConnector call super init with proper parameter name (#470) *70e02c8 [azp] Purge swss before installing the newly built deb package (#472) *15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (#468)

804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (sonic-net#463) 1e924ac Fix: ConfigDBConnector call super init with proper parameter name (sonic-net#470) 70e02c8 [azp] Purge swss before installing the newly built deb package (sonic-net#472) 15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (sonic-net#468)

Include below commits sonic-swss-common ``` 83d3351 2021-04-22 | [swig] fix ConfigDBConnector.db_name (#483) [Qi Luo] fdf296f 2021-04-09 | Fix: ConfigDBConnector call super init with proper parameter name (#470) [Qi Luo] 4f580e3 2021-03-26 | [swig] translate SonicV2Connector::keys return type from C++ vector<string> to Python list (#468) [Qi Luo] ``` sonic-snmpagent ``` c160c2b 2021-08-04 | CPU Spike because of redundant and flooded keyspace notifis handled (#230) [Vivek Reddy] a4dd3bf 2021-08-03 | Non-block reading counters to tolerate corrupted/delayed counters in COUNTERS_DB (#231) [Qi Luo] ```

804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (sonic-net#463) 1e924ac Fix: ConfigDBConnector call super init with proper parameter name (sonic-net#470) 70e02c8 [azp] Purge swss before installing the newly built deb package (sonic-net#472) 15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (sonic-net#468)

[config/acl] Support everflow config translation

d4aa596

taoyl-ms requested a review from lguohan April 1, 2017 02:08

Add more error message for test

a3ae2ba

taoyl-ms force-pushed the taoyl/mirror-cfg branch from 9b9bffa to a3ae2ba Compare April 4, 2017 14:40

jleveque added the Enhancement ➕ label Apr 4, 2017

taoyl-ms added 2 commits April 4, 2017 09:00

Merge branch 'master' into taoyl/mirror-cfg

87a9d36

Set up test enviroment to fix test fail

7b20462

lguohan reviewed Apr 6, 2017

View reviewed changes

Resolve CR comments

6f8ace4

lguohan approved these changes Apr 7, 2017

View reviewed changes

taoyl-ms merged commit ebed2d0 into sonic-net:master Apr 7, 2017

stcheng mentioned this pull request Jul 19, 2019

[submodule]: Update swss related submodules #3190

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

aclshow unittest (sonic-net#468)

f9d6df2

Signed-off-by: Roman Kachur <[email protected]>

renukamanavalan mentioned this pull request Nov 16, 2019

SONiC core dump utility #3499

Open

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

[Portsorch]: The mtu configuration on the port cannot be updated if t…

aef6a46

…he fec configuration is blank (sonic-net#468)

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468)

763c6cb

* ARM32 bit fixes, for 64bit printf format specifier Signed-off-by: Antony Rheneus <[email protected]>

Junchao-Mellanox mentioned this pull request Apr 17, 2021

[submodule] Update submodule for sonic-swss-common #7358

Merged

4 tasks

Junchao-Mellanox mentioned this pull request Apr 19, 2021

[submodule] Update submodule for sonic-swss-common #7361

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[config/acl] Support everflow config translation #468

[config/acl] Support everflow config translation #468

taoyl-ms commented Apr 1, 2017

lguohan Apr 6, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Apr 6, 2017 •

edited

Loading

lguohan Apr 6, 2017 •

edited by taoyl-ms

Loading

lguohan Apr 6, 2017 •

edited by taoyl-ms

Loading

lguohan left a comment

[config/acl] Support everflow config translation #468

[config/acl] Support everflow config translation #468

Conversation

taoyl-ms commented Apr 1, 2017

lguohan Apr 6, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

taoyl-ms Apr 6, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan Apr 6, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Apr 6, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

lguohan Apr 6, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Apr 6, 2017 •

edited

Loading

lguohan Apr 6, 2017 •

edited by taoyl-ms

Loading

lguohan Apr 6, 2017 •

edited by taoyl-ms

Loading