-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service] Added NAT entry into CONTAINER_FEATURE. Fixes #4247. #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Kokhan <[email protected]>
@jleveque , @SavchukRomanLv , please have a look |
msosyak
previously approved these changes
Mar 11, 2020
jleveque
suggested changes
Mar 11, 2020
retest vs |
jleveque
approved these changes
Mar 11, 2020
retest default please |
retest mellanox please |
retest vsimage please |
retest default please |
1 similar comment
retest default please |
retest vsimage please |
retest default please |
retest this please |
retest vs please |
retest vsimage please |
lguohan
approved these changes
Mar 12, 2020
abdosi
pushed a commit
that referenced
this pull request
Mar 20, 2020
* [Service] Added NAT entry into CONTAINER_FEATURE. Fixes #4247. Signed-off-by: Andriy Kokhan <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
… (sonic-net#4250) * [Service] Added NAT entry into CONTAINER_FEATURE. Fixes sonic-net#4247. Signed-off-by: Andriy Kokhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Kokhan [email protected]
- What I did
Added NAT entry into CONTAINER_FEATURE in config_db.json template