[monit] Build from source and patch to use MemAvailable value if available on system #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like some build errors |
|
Fixed. Builds have all passed. |
lguohan
reviewed
Dec 16, 2019
lguohan
approved these changes
Dec 16, 2019
|
Retest vsimage please |
|
This feature was merged into the upstream Monit codebase 4/2/20: https://bitbucket.org/tildeslash/monit/commits/1e420ea44a416cf23027fa850faf616d48a26cd6 It appears as though it will be available starting with version 5.27.0. Can confirm here once that version is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Monit now reports a more accurate percentage of used system memory. Without this patch, monit doesn't seem to properly take filesystems mounted as tmpfs into consideration when calculating used system memory.
- How I did it
Rather than installing the latest available monit Debian package (version 5.20.0-6 for Stretch), we instead clone the source tree, patch the source so as to use the "MemAvailable" value in /proc/meminfo if it is available, build the package from source and finally install our custom-built package in the SONiC host OS.
- How to verify it
Verify that the percentage of used system memory displayed by monit now matches the amount returned by other utilities, such as the
virtual_memory()function in the Python psutil module.