[Services] Restart Platform-monitor service upon unexpected critical process exit. #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Zhao <[email protected]>
in supervisord conf file. Signed-off-by: Yong Zhao <[email protected]>
critical processes file into dockerfile.j2. Signed-off-by: Yong Zhao <[email protected]>
platform-monitor if it attempts to restart this container more than 3 times in 20 minutes. Signed-off-by: Yong Zhao <[email protected]>
…CRIPT) into shared Makefile docker-platform-monitor.mk. Signed-off-by: Yong Zhao <[email protected]>
jleveque
approved these changes
Nov 5, 2019
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
…s exit. (sonic-net#3667) Signed-off-by: Yong Zhao <[email protected]> [Services] Restart Platform-monitor service upon unexpected critical process exit. (sonic-net#3689) Signed-off-by: Yong Zhao <[email protected]> Signed-off-by: Sangita Maity <[email protected]> RB=2126600 G=lnos-reviewers R=pchaudha,pmao,vapatil,zxu A=zxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restart Platform-monitor service if one of critical processes running in Platform-monitor container exited or crashed abnormally.
Generally I follow the framework created by Joe to implement this feature in Platform-monitor container.
First, add supervisor-proc-exit-listener event listener option in Supervisord configuration file in Platform-monitor docker container. Supervisord will read a list of critical processes for which to monitor the unexpected crashed and exited.
Second, configure Platform-monitor.service to always auto-restart the service if it stops, with a delay of 30 seconds. Also set a rate limit of 3 restarts within 20 minutes (1200 seconds).
On your switch device, please use docker ps command to list all running docker containers.
Then use docker exec -it container_id bash to login target container. Typing top command
on the shell will display all the processes dynamically and you will spot the process id of one
of the critical processes. Finally type the command kill -9 process_id to terminate one process.
After exiting the container, you can use watch -n 1 docker ps to dynamically see the restart
of Platform-monitor container.