Changes in sonic-buildimage to support the NAT feature #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you first fix the build problem? |
stepanblyschak
suggested changes
Oct 16, 2019
|
@kirankella Do you need to add 'natsyncd' to warm reboot finalizer list https://github.com/Azure/sonic-buildimage/blob/master/files/image_config/warmboot-finalizer/finalize-warmboot.sh#L6? |
@stepanblyschak Yes, it needs to be added in the finalizer list. Will update in the next patch. |
kirankella
force-pushed
the
nat_changes_in_sonic
branch
from
8249a6e to
04fa204
Compare
|
retest this please |
stepanblyschak
previously approved these changes
Dec 3, 2019
arlakshm
previously approved these changes
Dec 20, 2019
kirankella
dismissed stale reviews from arlakshm and stepanblyschak
via
3b87714
- Docker for NAT - installing the required tools iptables and conntrack for nat Signed-off-by: [email protected]
kirankella
force-pushed
the
nat_changes_in_sonic
branch
from
3b87714 to
031d8d6
Compare
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
|
retest vs please |
stepanblyschak
approved these changes
Jan 17, 2020
This was referenced Jan 22, 2020
arlakshm
approved these changes
Jan 30, 2020
abdosi
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Changes in sonic-buildimage for the NAT feature - Docker for NAT - installing the required tools iptables and conntrack for nat Signed-off-by: [email protected] * Add redis-tools dependencies in the docker nat compilation * Addressed review comments * add natsyncd to warm-boot finalizer list * addressed review comments * using swsscommon.DBConnector instead of swsssdk.SonicV2Connector * Enable NAT application in docker-sonic-vs
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
* Changes in sonic-buildimage for the NAT feature - Docker for NAT - installing the required tools iptables and conntrack for nat Signed-off-by: [email protected] * Add redis-tools dependencies in the docker nat compilation * Addressed review comments * add natsyncd to warm-boot finalizer list * addressed review comments * using swsscommon.DBConnector instead of swsssdk.SonicV2Connector * Enable NAT application in docker-sonic-vs
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
* Changes in sonic-buildimage for the NAT feature - Docker for NAT - installing the required tools iptables and conntrack for nat Signed-off-by: [email protected] * Add redis-tools dependencies in the docker nat compilation * Addressed review comments * add natsyncd to warm-boot finalizer list * addressed review comments * using swsscommon.DBConnector instead of swsssdk.SonicV2Connector * Enable NAT application in docker-sonic-vs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done include:
Depend on:
sonic-linux-kernel PR - sonic-net/sonic-linux-kernel#100
sonic-swss PR - sonic-net/sonic-swss#1059
Signed-off-by: [email protected]