-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pmon] Add new daemon "syseepromd" to pmon docker #2866
Conversation
retest please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor comment, otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keboliu: The event listener does not take care of the situation Guohan was concerned about. I think you misunderstood his comment. We are not concerned with clearing the syseeprom data from the DB when PMON exits; syseeprom data is static and should not change. However, the concern Guohan raised was that the STATE_DB could get cleared by other services (config reload, swss restart, etc.). We need a way to recognize the STATE_DB was cleared and repopulate the syseeprom info into the DB.
The SwSS restart scenario shouldn't be a problem because we have configured the PMon service as a dependent of SwSS via systemd. Thus, if SwSS gets restarted, so too should PMon get restarted. However, we still need a way to get notified that the STATE_DB was cleared so we can repopulate the info.
@jleveque I get the point. Given the demand for repopulating syseeprom info to state DB in any case if it was cleared, what's your view to change the one-shot scripts to a new daemon for populate syseeprom and monitor it? |
Approved. However, do not merge until submodule update has been included in this PR. |
@keboliu: sonic-net/sonic-platform-daemons#25 has been merged. Please update the submodule in this PR. |
retest vs please |
@jleveque submodule has been updated, ready for merge:) |
…atically (#15510) src/sonic-utilities * 43c85ef5 - (HEAD -> 202205, origin/202205) [dhcp-relay] Fix dhcp6relay counter issue (#2866) (10 hours ago) [Yaqiang Zhu] * e0333b5c - Revert "[config]config reload should generate sysinfo if missing (#2778)" (#2865) (10 hours ago) [jingwenxie] * e7eac6bf - [config] Generate sysinfo in single asic (#2856) (10 hours ago) [jingwenxie] * e42291bb - [config] Generate sysinfo as needed when override config (#2836) (10 hours ago) [jingwenxie]
…AD (#15532) #### Why I did it Update submodule sonic-utilities to the latest HEAD ``` 50296b90 - [202012][dhcp-relay] Fix dhcp6relay counter issue (#2866) (#2873) (Fri Jun 30 18:08:53 2023 +0800) <Yaqiang Zhu> 160030c4 - [202012][dhcp_relay] Add "Reconfigure", "Information-Request", "Malformed" counter options (#2844) (Sun Jun 11 20:35:30 2023 -0700) <kellyyeh> e6289ced - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (#2852) (Fri Jun 2 18:20:21 2023 +0000) <Yaqiang Zhu> 885082ec - correctly parsing complete ipv6 vnet info (#2827) (Thu May 25 06:01:40 2023 +0000) <Keith Lu> ``` ##### Work item tracking - Microsoft ADO 22635770
- What I did
Introduce a new daemon syseepromd to pmon, which will post syseeprom info to pmon when starting pmon, and will clear those info when stopping pmon, and will keep monitoring the DB in case the info was cleared.
this PR has a dependency on sonic-net/sonic-platform-daemons#25
- How I did it
- How to verify it
build an image include this PR to verify the state DB, thes syseeprom info should be there after pmon started, stop pmon and those info should be removed from the state DB.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)