-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Do not fail for minigraphs which do not have neighbors listed in <Devices> section #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ices> section Signed-off-by: Nadiya.Stetskovych <[email protected]>
lguohan
approved these changes
Feb 4, 2019
jleveque
approved these changes
Feb 4, 2019
Retest this please |
yxieca
pushed a commit
that referenced
this pull request
Mar 19, 2019
…isted in <Devices> section (#2522) Signed-off-by: Nadiya.Stetskovych <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…isted in <Devices> section (sonic-net#2522) Signed-off-by: Nadiya.Stetskovych <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…isted in <Devices> section (sonic-net#2522) Signed-off-by: Nadiya.Stetskovych <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…isted in <Devices> section (sonic-net#2522) Signed-off-by: Nadiya.Stetskovych <[email protected]>
8 tasks
prsunny
pushed a commit
that referenced
this pull request
Dec 22, 2022
Updating sonic-swss to latest to include following fixes - 0d91125 [bufferorch] : Support for buffer profiles for VoQ on chassis (#2465) 94429f1 Fixed a bug causing error state of same configuration is applied twice. (#2580) f1c0a75 Update FDB state table when , MAC entries are modified as dynamic_local. (#2575) beaac71 [voq][chassis]Add show fabric counters port/queue commands (#2522) 44d1e9c Fix test_vlan.py (#2541) c00455a Only collect stdout of orchagent_restart_check in vstest (#2578) def98d9 Remove TODO comments which are no longer needed (#2568)
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jan 5, 2023
…atform-common][py-swsssdk] advance submodule head linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) [noaOrMlnx] swss: * 7b3170a 2023-01-05 | Revert "sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552)" (HEAD -> 202205) [Ying Xie] * 4897e93 2023-01-05 | Revert "[bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465)" (HEAD -> 202205, github/202205) [Ying Xie] * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (sonic-net#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (sonic-net#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (sonic-net#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (sonic-net#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (sonic-net#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (sonic-net#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (sonic-net#655) (sonic-net#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
that referenced
this pull request
Jan 5, 2023
…atform-common][py-swsssdk] advance submodule head (#13260) linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (#2176) [noaOrMlnx] swss: * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (#655) (#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jan 12, 2023
…le head utilties: * 7fc3fb7 2023-01-06 | [storyteller] add link prober state change to story teller (sonic-net#2585) (HEAD -> 202205, github/202205) [Jing Zhang] * d8202e8 2023-01-12 | [202205] Added a new option in show queue counters command to display voq statistics (sonic-net#2591) [Sambath Kumar Balasubramanian] * 98dde31 2023-01-11 | resolved conflicts (sonic-net#2589) [kannankvs] swss: * 268c3f3 2023-01-11 | Added new attributes for Vnet and Vxlan ecmp configurations. (sonic-net#2584) (HEAD -> 202205, github/202205) [siqbal1986] * 50235b6 2023-01-12 | [routesync] Fix for stale dynamic neighbor (sonic-net#2553) [vganesan-nokia] * ad9d826 2023-01-12 | [202205][voq] Add voq counters. (sonic-net#2606) [Sambath Kumar Balasubramanian] * 34995f1 2023-01-10 | Revert "[voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522)" (sonic-net#2612) [Arvindsrinivasan Lakshmi Narasimhan] sairedis: * 92e6442 2023-01-05 | enable cisco8000 SAI bulk API feature (sonic-net#1153) (sonic-net#1164) (github/202205) [Keith Lu] platform-daemons: * 10eb2e6 2023-01-06 | Fix bug where transceiver info is missing after port breakout change (sonic-net#329) (HEAD -> 202205) [Tal Berlowitz] Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
that referenced
this pull request
Jan 13, 2023
…le head (#13353) utilties: * 7fc3fb7 2023-01-06 | [storyteller] add link prober state change to story teller (#2585) (HEAD -> 202205, github/202205) [Jing Zhang] * d8202e8 2023-01-12 | [202205] Added a new option in show queue counters command to display voq statistics (#2591) [Sambath Kumar Balasubramanian] * 98dde31 2023-01-11 | resolved conflicts (#2589) [kannankvs] swss: * 268c3f3 2023-01-11 | Added new attributes for Vnet and Vxlan ecmp configurations. (#2584) (HEAD -> 202205, github/202205) [siqbal1986] * 50235b6 2023-01-12 | [routesync] Fix for stale dynamic neighbor (#2553) [vganesan-nokia] * ad9d826 2023-01-12 | [202205][voq] Add voq counters. (#2606) [Sambath Kumar Balasubramanian] * 34995f1 2023-01-10 | Revert "[voq][chassis]Add show fabric counters port/queue commands (#2522)" (#2612) [Arvindsrinivasan Lakshmi Narasimhan] sairedis: * 92e6442 2023-01-05 | enable cisco8000 SAI bulk API feature (#1153) (#1164) (github/202205) [Keith Lu] platform-daemons: * 10eb2e6 2023-01-06 | Fix bug where transceiver info is missing after port breakout change (#329) (HEAD -> 202205) [Tal Berlowitz] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Feb 9, 2023
…aemons] advance submodule head linkmgrd: * e191338 2023-02-10 | Fix the warning of unused variables (sonic-net#167) (HEAD -> 202205) [Longxiang Lyu] utilities: * 2c933b0a 2023-02-07 | [sai_failure_dump]Invoking dump during SAI failure (sonic-net#2633) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] * e949f318 2023-02-07 | [show] add support for gRPC show commands for `active-active` (sonic-net#2629) [vdahiya12] * 77723927 2023-01-30 | Fixed admin state config CLI for Backport interfaces (sonic-net#2557) [anamehra] * 32b1d4d6 2023-02-01 | [masic support] 'show run bgp' support for multi-asic (sonic-net#2427) [wenyiz2021] * a2252d8a 2022-10-11 | Filter port invalid MTU configuration (sonic-net#2378) [pettershao-ragilenetworks] * 0ffb4b6a 2023-02-09 | Add Transceiver PM basic CLI support to show output from TRANSCEIVER_PM table for ZR (sonic-net#2655) (github/202205) [longhuan-cisco] * 496a0774 2023-02-09 | Add asic id for linecards so "show fabric counters queue/port" can work for single chip systems (sonic-net#2656) [jfeng-arista] * 2591e8b5 2023-02-03 | multi asic support for show queue counter (sonic-net#2647) [zhixzhu] swss: * e0373a4 2023-02-07 | [autoneg]Fixing adv interface types to be set when AN is disabled (sonic-net#2638) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam] * 62a09a0 2023-02-09 | [sai_failure_dump]Invoking dump during SAI failure (sonic-net#2644) (sonic-net#2661) [Sudharsan Dhamal Gopalarathnam] * 076f63e 2023-02-08 | [202205] Revert "Revert "[voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522)" (sonic-net#2612)" (sonic-net#2655) [kenneth-arista] * a35e074 2023-02-06 | [202205][voq][chassis] Remove created ports from the default vlan. (sonic-net#2651) [arista-nwolfe] swss-common: * b9d4284 2023-02-08 | [202205] Fix epoll and socket resource leak issue. (sonic-net#651) (sonic-net#741) (github/202205) [Kevin Petremann] sairedis: * 9d8e731 2023-02-08 | [Mellanox] Enable DSCP remapping by using SAI attribute (sonic-net#1188) (HEAD -> 202205, github/202205) [Stephen Sun] * 272a8bd 2023-02-10 | Fixing race condition for rif counters sonic-net#1136 (sonic-net#1202) [Suman Kumar] * 211365a 2023-02-08 | [202205][submodule][SAI]Advance SAI header (sonic-net#1207) [Richard.Yu] * 939c14b 2023-02-08 | [Submodule][upgrade]Upgrade SAI submodule (sonic-net#1203) [Richard.Yu] platform-daemons: * e5ccd40 2022-10-03 | [ycabled] fix naming error for error condition for CLI handling (sonic-net#302) (HEAD -> 202205, github/202205) [vdahiya12] * cdd354d 2022-09-29 | [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301) [vdahiya12] * cf58c08 2023-02-01 | Chassisd do an explicit stop of the config_manager (sonic-net#328) (sonic-net#336) [judyjoseph] Signed-off-by: Ying Xie <[email protected]>
8 tasks
yxieca
added a commit
that referenced
this pull request
Feb 10, 2023
…aemons] advance submodule head (#13755) linkmgrd: * e191338 2023-02-10 | Fix the warning of unused variables (#167) (HEAD -> 202205) [Longxiang Lyu] utilities: * 2c933b0a 2023-02-07 | [sai_failure_dump]Invoking dump during SAI failure (#2633) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] * e949f318 2023-02-07 | [show] add support for gRPC show commands for `active-active` (#2629) [vdahiya12] * 77723927 2023-01-30 | Fixed admin state config CLI for Backport interfaces (#2557) [anamehra] * 32b1d4d6 2023-02-01 | [masic support] 'show run bgp' support for multi-asic (#2427) [wenyiz2021] * a2252d8a 2022-10-11 | Filter port invalid MTU configuration (#2378) [pettershao-ragilenetworks] * 0ffb4b6a 2023-02-09 | Add Transceiver PM basic CLI support to show output from TRANSCEIVER_PM table for ZR (#2655) (github/202205) [longhuan-cisco] * 496a0774 2023-02-09 | Add asic id for linecards so "show fabric counters queue/port" can work for single chip systems (#2656) [jfeng-arista] * 2591e8b5 2023-02-03 | multi asic support for show queue counter (#2647) [zhixzhu] swss: * e0373a4 2023-02-07 | [autoneg]Fixing adv interface types to be set when AN is disabled (#2638) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam] * 62a09a0 2023-02-09 | [sai_failure_dump]Invoking dump during SAI failure (#2644) (#2661) [Sudharsan Dhamal Gopalarathnam] * 076f63e 2023-02-08 | [202205] Revert "Revert "[voq][chassis]Add show fabric counters port/queue commands (#2522)" (#2612)" (#2655) [kenneth-arista] * a35e074 2023-02-06 | [202205][voq][chassis] Remove created ports from the default vlan. (#2651) [arista-nwolfe] swss-common: * b9d4284 2023-02-08 | [202205] Fix epoll and socket resource leak issue. (#651) (#741) (github/202205) [Kevin Petremann] sairedis: * 9d8e731 2023-02-08 | [Mellanox] Enable DSCP remapping by using SAI attribute (#1188) (HEAD -> 202205, github/202205) [Stephen Sun] * 272a8bd 2023-02-10 | Fixing race condition for rif counters #1136 (#1202) [Suman Kumar] * 211365a 2023-02-08 | [202205][submodule][SAI]Advance SAI header (#1207) [Richard.Yu] * 939c14b 2023-02-08 | [Submodule][upgrade]Upgrade SAI submodule (#1203) [Richard.Yu] platform-daemons: * e5ccd40 2022-10-03 | [ycabled] fix naming error for error condition for CLI handling (#302) (HEAD -> 202205, github/202205) [vdahiya12] * cdd354d 2022-09-29 | [ycabled] add some exception catching logic to some vendor specific API's (#301) [vdahiya12] * cf58c08 2023-02-01 | Chassisd do an explicit stop of the config_manager (#328) (#336) [judyjoseph] Signed-off-by: Ying Xie <[email protected]>
mihirpat1
pushed a commit
to mihirpat1/sonic-buildimage
that referenced
this pull request
Jun 14, 2023
…#2522) What I did Enable show fabric counters port command: show fabric counters port ASIC PORT STATE IN_CELL IN_OCTET OUT_CELL OUT_OCTET CRC FEC_CORRECTABLE FEC_UNCORRECTABLE SYMBOL_ERR ------ ------ ------- --------- ---------- ---------- ----------- ----- ----------------- ------------------- ------------ 0 0 up 0 0 4 740 0 3 305128 3 0 1 up 0 0 4 740 0 314 232123 245 0 2 up 0 0 4 740 0 0 265156 0 ....... Enable show fabric counters queue command : ASIC PORT STATE QUEUE_ID CURRENT_BYTE CURRENT_LEVEL WATERMARK_LEVEL ------ ------ ------- ---------- -------------- --------------- ----------------- 0 0 up 0 N/A N/A N/A 0 1 up 0 N/A N/A N/A ......
mihirpat1
pushed a commit
to mihirpat1/sonic-buildimage
that referenced
this pull request
Jun 14, 2023
…onic-net#2522)" (sonic-net#2611) This reverts commit beaac71. Reverts sonic-net/sonic-swss#2522 Fixes sonic-net#13324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nadiya.Stetskovych [email protected]
- What I did
add a check if neighbors metadata exist
- How I did it
- How to verify it
apply
config load_minigraph -y
upon old minigraph without DEVICE_NEIGHBOR_METADATA- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)