Single image implementation #215

oleksandrivantsiv · 2017-01-25T20:08:39Z

generic image is fully backward compatible.
generic platform for now is default platform (make configure is not required for this platform).
add infrastructure required to build single image.
add single image for Mellanox platform only. "sonic-mellanox.bin" is default target.
add all required config files to single image.
add configuration files templates and generation of config file during startup.

oleksandrivantsiv · 2017-01-25T20:10:15Z

Single image templates implementation for Broadcom and Cavium platforms will be added as separated commits.

lguohan · 2017-01-26T02:15:55Z

can you check the build break?

sudo cp files/image_config/environment/environment ./fsroot/etc/
sudo cp files/image_config/environment/motd ./fsroot/etc/
sudo cp files/image_config/minigraph/minigraph_.xml ./fsroot/etc/sonic/minigraph.xml
cp: cannot stat 'files/image_config/minigraph/minigraph_.xml': No such file or directory

oleksandrivantsiv · 2017-01-26T08:26:54Z

Build failures reason is the following:

Cavium and Broadcom platform are not read yet. Will add changes soon.
Mellanox platform: Additional "SKU" parameter should be "make configure" command (example: make configure PLATFORM=mellanox SKU=ACS-MSN2700). Jenkins job should be changed.
Base image job is executed under Broadcom platform:

[buildimage-baseimage-pr] $ /bin/bash /tmp/hudson3572960011129076848.sh
platform/broadcom/rules.mk:1: /rules.mk: No such file or directory

Now it can be compiled under generic platform. Generic platform is default and "make configure" is not required for it any more. To compile image the following command should be executed:

make target/sonic-generic.bin

Jenkins job should be changed.

marian-pritsak · 2017-01-26T09:28:05Z

files/image_config/interfaces/lag_interfaces.j2

@@ -0,0 +1,20 @@
+#
+{% block banner %}
+# =========== Managed by Ansible DO NOT EDIT! ========================


Not ansible anymore
Maybe change to sonic-config engine?

marian-pritsak · 2017-01-26T09:32:29Z

platform/mellanox/single-image.mk

+SONIC_SINGLE_IMAGE = sonic-mellanox.bin
+$(SONIC_SINGLE_IMAGE)_MACHINE = mellanox
+$(SONIC_SINGLE_IMAGE)_IMAGE_TYPE = onie
+$(SONIC_SINGLE_IMAGE)_DEPENDS += $(SX_KERNEL) $(KERNEL_MFT) $(MFT)


hw-management?

lguohan · 2017-01-27T02:14:47Z

files/build_templates/sonic_debian_extension.j2

+[ -n "$FILESYSTEM_ROOT" ] || {
+    echo "Error: no or empty FILESYSTEM_ROOT argument"
+    exit 1
+}


can you add comment to describe what this mainly is doing?

maybe simply saying load docker images and configurations

In reply to: 98135052 [](ancestors = 98135052)

lguohan · 2017-01-27T02:16:15Z

files/build_templates/sonic_debian_extension.j2

+export debian_version=`cat $FILESYSTEM_ROOT/etc/debian_version`
+export kernel_version={{kversion}}
+j2 $BUILD_TEMPLATES/sysDescription.j2 > sysDescription 
+sudo mv sysDescription $FILESYSTEM_ROOT/etc/ssw/


taoyu, can you take a look at this to make sure we are generate the correct sonic version here.

lguohan · 2017-01-27T02:20:23Z

files/build_templates/docker_image_ctl.j2

+    if [ "$?" -eq "0" ]; then
+        docker start -a {{docker_container_name}}
+    else
+        docker run {{docker_image_run_opt}} --name={{docker_container_name}} {{docker_image_name}}


do you know how long it takes to run other than the start?

Approximately same time. Will do a measurement.

Docker run:

root@sonic:/home/admin# /usr/bin/swss.sh start Run docker swss: time in miliseconds 1485530349782 Inside docker swss: time in miliseconds 1485530349961 1485530349961 - 1485530349782 = 179 miliseconds

Docker start:

root@sonic:/home/admin# /usr/bin/swss.sh start Start docker swss: time in miliseconds 1485529942168 Inside docker swss: time in miliseconds 1485529942294 1485529942294 - 1485529942168 = 126 miliseconds

lguohan · 2017-01-27T02:37:23Z

since docker-base is not updated, you can remove it from the changeset

SKU should be provided during configure: make configure PLATFORM=broadcom SKU=Force10-S6000

SKU should be provided during configure: make configure PLATFORM=cavium SKU=AS7512

svc-acs · 2017-01-27T17:25:57Z

No test results found.

qiluo-msft · 2017-01-30T22:28:51Z

build_debian.sh

@@ -132,15 +132,6 @@ sudo chroot $FILESYSTEM_ROOT update-initramfs -u
 ## Install latest intel igb driver
 sudo cp target/debs/igb.ko $FILESYSTEM_ROOT/lib/modules/3.16.0-4-amd64/kernel/drivers/net/ethernet/intel/igb/igb.ko

-## Install package without starting service


Why remove this block?

qiluo-msft · 2017-01-30T22:32:44Z

files/image_config/ntp/ntp.conf.j2

@@ -0,0 +1,63 @@
+###############################################################################
+# Managed by Ansible
+# file: ansible/roles/acs/templates/ntp.conf.j2


Remove all the 'ansible' comments?

- Fix issue with session update observed when more than one session exist with destination IP address from the same subnet. - Fix issue with deletion of ACL rules attached to everflow session in inactive state.

Update sonic-snmpagent submodule to pick up new commits: 21d7d97 2021-07-12 Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226) 0813b42 2021-07-12 Entries under .1.3.6.1.2.1.31.1.1.1.18 OID should return the "description" field of PORT_TABLE entries in APPL_DB or CONFIG_DB. (#224) 7a78703 2021-07-08 Install dotnet core to fix python gcov warning for code covery color bar showing (#215) e0f36a5 2021-06-30 [multi-asic]: Udpate to use SonicDBConfig from swsscommon (#219) 266bd15 2021-06-10 Restored snmp vlan support per RFC1213 and added the missing support for RFC2863 (#218)

14a4212 [Marvell] CPU1 failure on continuous reboot (#228) 53e75e5 hwmon: (pmbus_core) Do not enable PEC if adapter doesn't (#215) Signed-off-by: Rajkumar Pennadam Ramamoorthy <[email protected]>

Update sonic-snmpagent submodule to pick up new commits: 21d7d97 2021-07-12 Fix: SonicV2Connector behavior change: get_all will return empty dict if (sonic-net#226) 0813b42 2021-07-12 Entries under .1.3.6.1.2.1.31.1.1.1.18 OID should return the "description" field of PORT_TABLE entries in APPL_DB or CONFIG_DB. (sonic-net#224) 7a78703 2021-07-08 Install dotnet core to fix python gcov warning for code covery color bar showing (sonic-net#215) e0f36a5 2021-06-30 [multi-asic]: Udpate to use SonicDBConfig from swsscommon (sonic-net#219) 266bd15 2021-06-10 Restored snmp vlan support per RFC1213 and added the missing support for RFC2863 (sonic-net#218)

14a4212 [Marvell] CPU1 failure on continuous reboot (sonic-net#228) 53e75e5 hwmon: (pmbus_core) Do not enable PEC if adapter doesn't (sonic-net#215) Signed-off-by: Rajkumar Pennadam Ramamoorthy <[email protected]>

8bb9c5a (HEAD -> master, origin/master, origin/HEAD) Add retry reading/setting mux status to simulated y-cable driver (#221) 2ebd786 [sfp-refactor] Add initial support for SFF-8636 in sonic_xcvr (#218) 221fb8a Fix QSFP-DD power class mask (#212) 4598d40 [Y-Cable][Broadcom] upgrade to support Broadcom Y-Cable API to release 1.2 (#217) 0fdd198 [sfp-refactor] Add initial support for SFF-8436 in sonic_xcvr (#215) a09f5a3 [sfp-refactor] Add new sonic_xcvr package for common transceiver logic (#201) 7ca4f51 Update SFP index definition (#214) Signed-off-by: vaibhav-dahiya <[email protected]>

Due to rare timing issue test_sfp_insert_events failure can fail. Out of 100 iterations, the test failed on 82nd iteration. Signed-off-by: Prince George <[email protected]>

…bar showing (sonic-net#215) **- What I did** fix python gcov warning "Please install dotnet core to enable automatic generation of Html report" **- How I did it** install dotnet core

…net#215)

Currently, for Packet Error Checking (PEC) only the controller is checked for support. This causes problems on the cisco-8000 platform where a SMBUS transaction errors are observed. This is because PEC has to be enabled only if both controller and adapter supports it. Added code to check PEC capability for adapter and enable it only if both controller and adapter supports PEC. Signed-off-by: Madhava Reddy Siddareddygari <[email protected]>

#15952) #### Why I did it src/linkmgrd ``` * aa902a3 - (HEAD -> master, origin/master, origin/HEAD) [link prober] Increase pause/restart probe log verbosity (#213) (3 days ago) [Longxiang Lyu] * 736cdda - [active-standby] Write `unhealthy` is default route `N/A` (#214) (3 days ago) [Longxiang Lyu] * e923e15 - Add ADO to the PR template (#215) (4 days ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog

#16105) src/linkmgrd * 6ce71ba - (HEAD -> 202205, origin/202205) Add ADO to the PR template (#215) (4 hours ago) [Longxiang Lyu] * 1010d93 - [active-standby] Write `unhealthy` is default route `N/A` (#214) (4 hours ago) [Longxiang Lyu] * 15e9ca2 - [link prober] Increase pause/restart probe log verbosity (#213) (4 hours ago) [Longxiang Lyu]

#16152) #### Why I did it src/linkmgrd ``` * 40113fd - (HEAD -> 202305, origin/202305) [active-standby] Fix extra toggle observed in `config reload` (#216) (2 days ago) [Longxiang Lyu] * b6d40fc - Add ADO to the PR template (#215) (2 days ago) [Longxiang Lyu] * fe41ad2 - [active-standby] Write `unhealthy` is default route `N/A` (#214) (2 days ago) [Longxiang Lyu] * 8ff265c - [link prober] Increase pause/restart probe log verbosity (#213) (2 days ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog

sonic-net#15952) #### Why I did it src/linkmgrd ``` * aa902a3 - (HEAD -> master, origin/master, origin/HEAD) [link prober] Increase pause/restart probe log verbosity (sonic-net#213) (3 days ago) [Longxiang Lyu] * 736cdda - [active-standby] Write `unhealthy` is default route `N/A` (sonic-net#214) (3 days ago) [Longxiang Lyu] * e923e15 - Add ADO to the PR template (sonic-net#215) (4 days ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog

Why I did it To integrate ZMQ to GNMI and Orchagent, need update sonic-swss submodule to latest code. How I did it How to verify it

Cherry-pick 17483 and 17378 from public master to msft/202205

marian-pritsak suggested changes Jan 26, 2017

View reviewed changes

marian-pritsak approved these changes Jan 26, 2017

View reviewed changes

lguohan reviewed Jan 27, 2017

View reviewed changes

lguohan approved these changes Jan 27, 2017

View reviewed changes

oleksandrivantsiv mentioned this pull request Jan 27, 2017

Impossible to build platform independent docker container #120

Closed

oleksandrivantsiv added 6 commits January 27, 2017 16:35

Single image

2eeb822

Fix review comments

b0dfd13

Update syncd service. Add HW mgmt to Mellanox single image.

144a1c8

Add single image template for Broadcom platform.

3460ffd

SKU should be provided during configure: make configure PLATFORM=broadcom SKU=Force10-S6000

Add single image template for Cavium platform.

4a4bb64

SKU should be provided during configure: make configure PLATFORM=cavium SKU=AS7512

Add description to sonic_debian_extension.j2 file.

97ed637

lguohan merged commit 34ea913 into sonic-net:master Jan 29, 2017

qiluo-msft reviewed Jan 30, 2017

View reviewed changes

xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Feb 16, 2021

Exclude some large files in archiveArtifacts (sonic-net#215)

6ae2e49

raphaelt-nvidia mentioned this pull request Jul 13, 2021

[submodule] Update sonic-snmpagent submodule #7859

Merged

rajkumar38 mentioned this pull request Jul 14, 2021

[sonic-linux-kernel] submodule update #8182

Merged

5 tasks

vdahiya12 mentioned this pull request Oct 20, 2021

[sonic-platform-common] submodule update #9022

Merged

5 tasks

vdahiya12 mentioned this pull request May 31, 2022

[sonic-platform-common][sonic-platform-daemons]submodule update #10993

Merged

6 tasks

snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023

[sfp-refactor] Add initial support for SFF-8436 in sonic_xcvr (sonic-…

0fdd198

…net#215)

vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Mar 18, 2024

Update sonic-swss submodule (sonic-net#215)

0fc5d34

Why I did it To integrate ZMQ to GNMI and Orchagent, need update sonic-swss submodule to latest code. How I did it How to verify it

mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024

Merge pull request sonic-net#215 from gechiang/202205

b1bff3d

Cherry-pick 17483 and 17378 from public master to msft/202205

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Single image implementation #215

Single image implementation #215

oleksandrivantsiv commented Jan 25, 2017

oleksandrivantsiv commented Jan 25, 2017

lguohan commented Jan 26, 2017

oleksandrivantsiv commented Jan 26, 2017

marian-pritsak Jan 26, 2017

marian-pritsak Jan 26, 2017

lguohan Jan 27, 2017

lguohan Jan 27, 2017

oleksandrivantsiv Jan 27, 2017

lguohan Jan 27, 2017

lguohan Jan 27, 2017

oleksandrivantsiv Jan 27, 2017

oleksandrivantsiv Jan 27, 2017

lguohan commented Jan 27, 2017

svc-acs commented Jan 27, 2017

qiluo-msft Jan 30, 2017

qiluo-msft Jan 30, 2017

Single image implementation #215

Single image implementation #215

Conversation

oleksandrivantsiv commented Jan 25, 2017

oleksandrivantsiv commented Jan 25, 2017

lguohan commented Jan 26, 2017

oleksandrivantsiv commented Jan 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Jan 27, 2017

svc-acs commented Jan 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment