[action] [PR:17784] [dualtor] Disable zebra link-detect for vlan interfaces #17936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
If all vlan member ports are admin down, the vlan route is removed by FRR, so the packets to the vlan subnet will be forwarded with the default route, two issues:
the vlan route in kernel still has nexthop as the vlan device, the vlan route in ASIC has nexthop as the default route.
As those traffic will be bounced back to T1s by the ASIC, they will not be able to be trapped to kernel to trigger the zero-mac tunnel route creation.
For dualtor, the downstream standby traffic should be tunneled to the active side.
To ensure the zero-mac tunnel route works as expected, the vlan route should always present in both the kernel and ASIC.
So let's disable the link-detect for vlan interfaces.
Fixes: #16085
Signed-off-by: Longxiang Lyu [email protected]
Work item tracking
How I did it
Disable the
link-detect
flag in the frr zebra template.How to verify it
UT and nightly run.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)