Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:17784] [dualtor] Disable zebra link-detect for vlan interfaces #17936

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

mssonicbld
Copy link
Collaborator

Why I did it

If all vlan member ports are admin down, the vlan route is removed by FRR, so the packets to the vlan subnet will be forwarded with the default route, two issues:

  1. route inconsistency between kernel and ASIC.
    the vlan route in kernel still has nexthop as the vlan device, the vlan route in ASIC has nexthop as the default route.
  2. no tunnel will be created.
    As those traffic will be bounced back to T1s by the ASIC, they will not be able to be trapped to kernel to trigger the zero-mac tunnel route creation.

For dualtor, the downstream standby traffic should be tunneled to the active side.
To ensure the zero-mac tunnel route works as expected, the vlan route should always present in both the kernel and ASIC.
So let's disable the link-detect for vlan interfaces.

Fixes: #16085

Signed-off-by: Longxiang Lyu [email protected]

Work item tracking
  • Microsoft ADO (number only): 26325737

How I did it

Disable the link-detect flag in the frr zebra template.

How to verify it

UT and nightly run.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

)

* [dualtor] Disable zebra link-detect for vlan interfaces

Signed-off-by: Longxiang Lyu <[email protected]>
@mssonicbld
Copy link
Collaborator Author

Original PR: #17784

@mssonicbld mssonicbld merged commit 06c27e5 into sonic-net:202305 Jan 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants