[202311][cherry-pick][NTP] Add NTP extended configuration #17487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastiuk
changed the title
|
@fastiuk this seems to be a feature PR. I don't think we should cherry-pick feature PR(s) into a release branch. |
It is. But 4 out of 5 PRs for this feature were merged, and are part of 202311. So I think it is mandatory to cherry-pick the last one |
|
@fastiuk test_ntp is consistently failure. Can you make the test compatible with before and after this change? |
fastiuk
force-pushed
the
dev-ntp-configuration
branch
2 times, most recently
from
7104c73 to
9a16bf3
Compare
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
9a16bf3 to
2ea6582
Compare
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
…access for other. Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
* Align the description for setting interface * Fix the usage of scoped variable Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
2ea6582 to
ec1d0d4
Compare
|
Commenter does not have sufficient privileges for PR 17487 in repo sonic-net/sonic-buildimage |
1 similar comment
|
Commenter does not have sufficient privileges for PR 17487 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tests passed. Please merge it |
|
@yxieca Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hld #1296
closes #1254
cherry-picks #15058
Why I did it
To cover the next AIs:
How I did it
Description for the changelog
Link to config_db schema for YANG module changes
NTP configuration
A picture of a cute animal (it is my cat Finn)