Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_server] add show dhcp server info #17468

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

Xichen96
Copy link
Contributor

@Xichen96 Xichen96 commented Dec 10, 2023

Why I did it

Add show dhcp_server info

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add new subcommand to show dhcp_server command.

How to verify it

Add unit tests for compile time testing. Manually run command in latest master image.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Latest master image

Description for the changelog

Add show dhcp_server info

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@Xichen96 Xichen96 requested a review from lguohan as a code owner December 10, 2023 18:24
Copy link
Contributor

@yaqiangz yaqiangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xichen96
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Xichen96
Copy link
Contributor Author

@yxieca Checks have now passed. Could you help review?

@yxieca yxieca merged commit 1e92ba2 into sonic-net:master Dec 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants