Buffers config #1476
Merged
Buffers config #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda <[email protected]>
Signed-off-by: Wenda <[email protected]>
lguohan
requested changes
Mar 8, 2018
yxieca
reviewed
Mar 9, 2018
|
@yxieca Does the old config still work? If so, I prefer updating to the new one in a separate PR. |
|
The old one still work. You can update in a separate PR. Cheers, |
lguohan
approved these changes
Mar 10, 2018
|
short reminder: Use squash and merge to update the commit message and check in the commit 🍺 |
|
🍻 |
4 tasks
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Mar 5, 2021
- [201911][acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1477) - [201911][acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1476) - [201911][acl-loader] Improve input validation for acl_loader (sonic-net#1481) Signed-off-by: Danny Allen <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Mar 5, 2021
- [201911][acl] Expand VLAN into VLAN members when creating an ACL table (#1477) - [201911][acl-loader] Add support for matching on ICMP and VLAN info (#1476) - [201911][acl-loader] Improve input validation for acl_loader (#1481) Signed-off-by: Danny Allen <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Improve memory utilization and robustness to traffic burstiness through better buffer sharing at the ingress
- How I did it
Consolidate the buffer pools of PG 3 and 4.
Reduce the size of dedicated buffers per port per lossless PG to leave buffer space for shared pool.
Use dynamic threshold to absorb burstiness while maintain fairness.
- How to verify it
Verified the config on A7050-QX-32S:
Tested ingress PG pool sizing
Tested ingress xon offset
Tested ECN min threshold and max threshold
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)