-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install netifaces package in sonic-slave docker and sonic image #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=
This reverts commit c9a2c92.
This reverts commit 45ab087.
Sync to master
Sync to master
Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.
…ling to a more relevant place for this cmd. Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.
…ling to a more relevant place for this cmd. Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.
Sync to master
…tysh on host system. RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=
Sync to master
lguohan
approved these changes
Jan 30, 2018
better to rename the commit message to install netifaces package in sonic-slave docker. |
nikos-github
changed the title
show [ip|ipv6] interfaces cmds
Installing netifaces package in sonic-slave docker
Jan 30, 2018
nikos-github
changed the title
Installing netifaces package in sonic-slave docker
Install netifaces package in sonic-slave docker
Jan 30, 2018
@lguohan Please review this again. |
nikos-github
changed the title
Install netifaces package in sonic-slave docker
Install netifaces package in sonic-slave docker and sonic image
Jan 31, 2018
lguohan
reviewed
Feb 1, 2018
lguohan
requested changes
Feb 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add dependency in docker-sonic-vs as well.
@lguohan Comments addressed. |
retest this please |
1 similar comment
retest this please |
lguohan
approved these changes
Dec 15, 2018
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Jul 19, 2020
* d2bab10 2020-07-19 | [vstest]: use BytesIO for file operations [lguohan] * 982c9a3 2020-07-18 | [vstest]: fix vstest for python3 (sonic-net#1354) [lguohan] * ffa0dc3 2020-07-16 | [vstest]: clean up processes in server namespace at start (sonic-net#1353) [lguohan] * b16368c 2020-07-15 | [aclorch.cpp] Handle all the ACL redirect requests in AclRuleL3::validateAddAction() (sonic-net#1278) [madhanmellanox] * 310e0aa 2020-07-15 | [portsorch,intfsorch] add port, rif rates FC groups (sonic-net#1201) [Mykola F] * 5ddea37 2020-07-09 | [NAT]: Update NAT conntrack entries from natmgr instead of natorch (sonic-net#1274) [Akhilesh Samineni] * 94c622f 2020-07-07 | [aclorch] Use IPv6 Next Header internally for protocol number on MLNX platform (sonic-net#1343) [Danny Allen] * 82d36c4 2020-07-07 | support swss vstest in python3 [lguohan] |\ | * ff04e6d 2020-06-27 | [doc]: update instruction to run vstest under python3 [Guohan Lu] | * c90b281 2020-07-05 | [vstest]: reuse dvs setReadOnlyAttr in test_crm.py [Guohan Lu] | * 8807b40 2020-07-05 | [vstest]: fix string format compatibility issue for python2 and swig [Guohan Lu] | * 26efbcf 2020-07-04 | [vstest]: change float division to integer division [Guohan Lu] | * 6adaf2e 2020-07-04 | [vstest]: change time.clock() to time.time() [Guohan Lu] | * 9c71203 2020-07-04 | [vstest]: let redis decodes the response to be string instead of bytes [Guohan Lu] | * c7c63ee 2020-06-27 | [vstest]: change from platform to distro [Guohan Lu] | * d7ff1ad 2020-06-27 | [vstest]: upgrade swss vs tests to python3 [Guohan Lu] * | 2ebd44e 2020-07-03 | [sonic-swss] ARMHF warning fixes (sonic-net#1325) [[email protected]] * | 10ad70c 2020-07-02 | [swss] Add support for gearbox phys (sonic-net#1321) [Syd Logan] Signed-off-by: Guohan Lu <[email protected]>
lguohan
added a commit
that referenced
this pull request
Jul 20, 2020
* d2bab10 2020-07-19 | [vstest]: use BytesIO for file operations [lguohan] * 982c9a3 2020-07-18 | [vstest]: fix vstest for python3 (#1354) [lguohan] * ffa0dc3 2020-07-16 | [vstest]: clean up processes in server namespace at start (#1353) [lguohan] * b16368c 2020-07-15 | [aclorch.cpp] Handle all the ACL redirect requests in AclRuleL3::validateAddAction() (#1278) [madhanmellanox] * 310e0aa 2020-07-15 | [portsorch,intfsorch] add port, rif rates FC groups (#1201) [Mykola F] * 5ddea37 2020-07-09 | [NAT]: Update NAT conntrack entries from natmgr instead of natorch (#1274) [Akhilesh Samineni] * 94c622f 2020-07-07 | [aclorch] Use IPv6 Next Header internally for protocol number on MLNX platform (#1343) [Danny Allen] * 82d36c4 2020-07-07 | support swss vstest in python3 [lguohan] |\ | * ff04e6d 2020-06-27 | [doc]: update instruction to run vstest under python3 [Guohan Lu] | * c90b281 2020-07-05 | [vstest]: reuse dvs setReadOnlyAttr in test_crm.py [Guohan Lu] | * 8807b40 2020-07-05 | [vstest]: fix string format compatibility issue for python2 and swig [Guohan Lu] | * 26efbcf 2020-07-04 | [vstest]: change float division to integer division [Guohan Lu] | * 6adaf2e 2020-07-04 | [vstest]: change time.clock() to time.time() [Guohan Lu] | * 9c71203 2020-07-04 | [vstest]: let redis decodes the response to be string instead of bytes [Guohan Lu] | * c7c63ee 2020-06-27 | [vstest]: change from platform to distro [Guohan Lu] | * d7ff1ad 2020-06-27 | [vstest]: upgrade swss vs tests to python3 [Guohan Lu] * | 2ebd44e 2020-07-03 | [sonic-swss] ARMHF warning fixes (#1325) [[email protected]] * | 10ad70c 2020-07-02 | [swss] Add support for gearbox phys (#1321) [Syd Logan] Signed-off-by: Guohan Lu <[email protected]>
This was referenced Jan 28, 2021
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Feb 1, 2021
* c2fb282 2021-01-29 | [ecnconfig] Allow ecn unit test to run without sudo (sonic-net#1390) [Neetha John] * 6cc635b 2021-01-29 | [sonic-installer] Add information to syslog (sonic-net#1369) [Dmytro] * 7a8024a 2021-01-27 | Prevent user from adding more then a single untagged VLAN to an interface (sonic-net#1382) [Eran Dahan] * 41e62c6 2021-01-26 | [pcieutil] Add 'pcie-aer' sub-command to display AER stats (sonic-net#1169) [Arun Saravanan Balachandran] * 47f412b 2021-01-26 | Improve robustness of consutil plugin loading (sonic-net#1353) [Samuel Angebault] * 64aa1b8 2021-01-25 | [show] Fix warnings, related to gearbox, while show commands execution (sonic-net#1343) [maksymbelei95] * ff226d0 2021-01-25 | Prevent configuring IP interface on a port which is a member of VLAN (sonic-net#1374) [Eran Dahan] * f1522b9 2021-01-21 | [config_mgmt.py]: Set leaf-list to empty list while port breakout. (sonic-net#1268) [Praveen Chaudhary] * 99c05d5 2021-01-21 | add vlan_intf_object only if there are ipv4 or ipv6 mappings (sonic-net#1377) [Sumukha Tumkur Vani] * b082684 2021-01-21 | [ecn] Add tests for ecnconfig command (sonic-net#1372) [Neetha John] * 23e0920 2021-01-21 | [sfpshow] Enhance QSFP-DD DOM information (sonic-net#1207) [shlomibitton] * f4edba1 2021-01-20 | [ecnconfig] handle backend port names when extracting port I/F ID from the port name (sonic-net#1361) [Mahesh Maddikayala] Signed-off-by: Danny Allen <[email protected]>
4 tasks
daall
added a commit
that referenced
this pull request
Feb 2, 2021
* c2fb282 2021-01-29 | [ecnconfig] Allow ecn unit test to run without sudo (#1390) [Neetha John] * 6cc635b 2021-01-29 | [sonic-installer] Add information to syslog (#1369) [Dmytro] * 7a8024a 2021-01-27 | Prevent user from adding more then a single untagged VLAN to an interface (#1382) [Eran Dahan] * 41e62c6 2021-01-26 | [pcieutil] Add 'pcie-aer' sub-command to display AER stats (#1169) [Arun Saravanan Balachandran] * 47f412b 2021-01-26 | Improve robustness of consutil plugin loading (#1353) [Samuel Angebault] * 64aa1b8 2021-01-25 | [show] Fix warnings, related to gearbox, while show commands execution (#1343) [maksymbelei95] * ff226d0 2021-01-25 | Prevent configuring IP interface on a port which is a member of VLAN (#1374) [Eran Dahan] * f1522b9 2021-01-21 | [config_mgmt.py]: Set leaf-list to empty list while port breakout. (#1268) [Praveen Chaudhary] * 99c05d5 2021-01-21 | add vlan_intf_object only if there are ipv4 or ipv6 mappings (#1377) [Sumukha Tumkur Vani] * b082684 2021-01-21 | [ecn] Add tests for ecnconfig command (#1372) [Neetha John] * 23e0920 2021-01-21 | [sfpshow] Enhance QSFP-DD DOM information (#1207) [shlomibitton] * f4edba1 2021-01-20 | [ecnconfig] handle backend port names when extracting port I/F ID from the port name (#1361) [Mahesh Maddikayala] Signed-off-by: Danny Allen <[email protected]>
4 tasks
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Feb 4, 2021
* 28d358f 2021-02-01 | [show] Run fwutil with sudo (sonic-net#1364) (HEAD) [Volodymyr Boiko] * a50b7a2 2021-01-29 | [ecnconfig] Allow ecn unit test to run without sudo (sonic-net#1390) [Neetha John] * 8a1109e 2021-01-29 | [sonic-installer] Add information to syslog (sonic-net#1369) [Dmytro] * c7c01e4 2021-01-27 | [show] fix "show interfaces breakout" command (sonic-net#1198) [Dmytro Shevchuk] * 7a8024a 2021-01-27 | Prevent user from adding more then a single untagged VLAN to an interface (sonic-net#1382) [Eran Dahan] * 41e62c6 2021-01-26 | [pcieutil] Add 'pcie-aer' sub-command to display AER stats (sonic-net#1169) [Arun Saravanan Balachandran] * 47f412b 2021-01-25 | Improve robustness of consutil plugin loading (sonic-net#1353) [Samuel Angebault] * 64aa1b8 2021-01-26 | [show] Fix warnings, related to gearbox, while show commands execution (sonic-net#1343) [maksymbelei95] * ff226d0 2021-01-25 | Prevent configuring IP interface on a port which is a member of VLAN (sonic-net#1374) [Eran Dahan] * f1522b9 2021-01-21 | [config_mgmt.py]: Set leaf-list to empty list while port breakout. (sonic-net#1268) [Praveen Chaudhary] lgh@p330:~/sonic/sonic-buildimage/src/sonic-utilities$ git hist -n 20 * 28d358f 2021-02-01 | [show] Run fwutil with sudo (sonic-net#1364) (HEAD) [Volodymyr Boiko] * a50b7a2 2021-01-29 | [ecnconfig] Allow ecn unit test to run without sudo (sonic-net#1390) [Neetha John] * 8a1109e 2021-01-29 | [sonic-installer] Add information to syslog (sonic-net#1369) [Dmytro] * c7c01e4 2021-01-27 | [show] fix "show interfaces breakout" command (sonic-net#1198) [Dmytro Shevchuk] * 7a8024a 2021-01-27 | Prevent user from adding more then a single untagged VLAN to an interface (sonic-net#1382) [Eran Dahan] * 41e62c6 2021-01-26 | [pcieutil] Add 'pcie-aer' sub-command to display AER stats (sonic-net#1169) [Arun Saravanan Balachandran] * 47f412b 2021-01-25 | Improve robustness of consutil plugin loading (sonic-net#1353) [Samuel Angebault] * 64aa1b8 2021-01-26 | [show] Fix warnings, related to gearbox, while show commands execution (sonic-net#1343) [maksymbelei95] * ff226d0 2021-01-25 | Prevent configuring IP interface on a port which is a member of VLAN (sonic-net#1374) [Eran Dahan] * f1522b9 2021-01-21 | [config_mgmt.py]: Set leaf-list to empty list while port breakout. (sonic-net#1268) [Praveen Chaudhary] * 99c05d5 2021-01-21 | add vlan_intf_object only if there are ipv4 or ipv6 mappings (sonic-net#1377) [Sumukha Tumkur Vani] * b082684 2021-01-21 | [ecn] Add tests for ecnconfig command (sonic-net#1372) [Neetha John] * 23e0920 2021-01-21 | [sfpshow] Enhance QSFP-DD DOM information (sonic-net#1207) [shlomibitton] * f4edba1 2021-01-20 | [ecnconfig] handle backend port names when extracting port I/F ID from the port name (sonic-net#1361) [Mahesh Maddikayala] Signed-off-by: Guohan Lu <[email protected]>
4 tasks
lguohan
added a commit
that referenced
this pull request
Feb 4, 2021
* 28d358f 2021-02-01 | [show] Run fwutil with sudo (#1364) (HEAD) [Volodymyr Boiko] * a50b7a2 2021-01-29 | [ecnconfig] Allow ecn unit test to run without sudo (#1390) [Neetha John] * 8a1109e 2021-01-29 | [sonic-installer] Add information to syslog (#1369) [Dmytro] * c7c01e4 2021-01-27 | [show] fix "show interfaces breakout" command (#1198) [Dmytro Shevchuk] * 7a8024a 2021-01-27 | Prevent user from adding more then a single untagged VLAN to an interface (#1382) [Eran Dahan] * 41e62c6 2021-01-26 | [pcieutil] Add 'pcie-aer' sub-command to display AER stats (#1169) [Arun Saravanan Balachandran] * 47f412b 2021-01-25 | Improve robustness of consutil plugin loading (#1353) [Samuel Angebault] * 64aa1b8 2021-01-26 | [show] Fix warnings, related to gearbox, while show commands execution (#1343) [maksymbelei95] * ff226d0 2021-01-25 | Prevent configuring IP interface on a port which is a member of VLAN (#1374) [Eran Dahan] * f1522b9 2021-01-21 | [config_mgmt.py]: Set leaf-list to empty list while port breakout. (#1268) [Praveen Chaudhary] * 99c05d5 2021-01-21 | add vlan_intf_object only if there are ipv4 or ipv6 mappings (#1377) [Sumukha Tumkur Vani] * b082684 2021-01-21 | [ecn] Add tests for ecnconfig command (#1372) [Neetha John] * 23e0920 2021-01-21 | [sfpshow] Enhance QSFP-DD DOM information (#1207) [shlomibitton] * f4edba1 2021-01-20 | [ecnconfig] handle backend port names when extracting port I/F ID from the port name (#1361) [Mahesh Maddikayala] Signed-off-by: Guohan Lu <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
The configuration file does not tolerate a new line. Enhance the plugin loading by allowing trailing chars. Signed-off-by: Jing Kan [email protected]
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…1353) Signed-off-by: Guohan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change required for sonic-net/sonic-utilities#194