Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arista]: Fix the udev waiting in networking start #1093

Merged
merged 2 commits into from
Oct 31, 2017
Merged

[Arista]: Fix the udev waiting in networking start #1093

merged 2 commits into from
Oct 31, 2017

Conversation

byu343
Copy link
Contributor

@byu343 byu343 commented Oct 30, 2017

This change is to fix the issue in aristanetworks/sonic#16
We noticed that the long waiting time in service networking start is because the original 'udevadm settle' waits for some irrelevant devices. By the change, only eth0 is waited for.
For the checking condition used, this change is only applied to Arista switches

Signed-off-by: Boyang Yu [email protected]

@byu343
[Arista]: Fix the udev waiting in networking start
77c92a0 
This change is to fix the issue in aristanetworks/sonic#16
For the checking condition used, it is only applied to Arista switches

Signed-off-by: Boyang Yu <[email protected]>
@prsunny
Copy link
Contributor

prsunny commented Oct 30, 2017

I took this change and compiled but showing a permission denied issue while building "aboot" image in my VM. Just want to ensure this doesn't happen in release build.

Logs:

  • '[' aboot = aboot ']'
  • sed -i 's/udevadm settle/udevadm settle -E /sys/class/net/eth0/' ./fsroot/etc/init.d/networking
    sed: couldn't open temporary file ./fsroot/etc/init.d/sedpzcvcA: Permission denied

@prsunny
Copy link
Contributor

prsunny commented Oct 30, 2017

Changes looks good. I compiled it in my local repo and tested on A7060. eth0 is coming up as soon as logged in.

@prsunny prsunny self-requested a review October 30, 2017 23:09
@prsunny prsunny merged commit d7d6c41 into sonic-net:master Oct 31, 2017
daall added a commit to daall/sonic-buildimage that referenced this pull request Nov 19, 2019
@daall
[submodule]: Update sairedis/swss/utilities
eaec673 
sairedis:
* [SAI] Update SAI submodule to v1.5.1 (sonic-net#532)
* Cleanup Makefile.am from BFN specific code (sonic-net#530)
* [vs] Implement indices for debug counters in VS (sonic-net#531)
* Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529)
* [flex_counter] Add sairedis support for drop counters (sonic-net#520)

swss:
* [orchagent] Add swss support for drop counters (sonic-net#1075)
* [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129)
* [utilities] Create utility classes for interacting with flex counters (sonic-net#1093)
* [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809)
* Fix traceroute issue (sonic-net#1113)

utilities:
* Add CLI support for configurable drop counters (sonic-net#688)
* Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741)
* SONiC Management Framework Release 1.0 (sonic-net#659)

Signed-off-by: Danny Allen <[email protected]>
@daall daall mentioned this pull request Nov 19, 2019
Merged
lguohan pushed a commit that referenced this pull request Nov 21, 2019
@daall @lguohan
[submodule]: Update sairedis/swss/utilities (#3786)
cb2e01d 
sairedis:
* [SAI] Update SAI submodule to v1.5.1 (#532)
* Cleanup Makefile.am from BFN specific code (#530)
* [vs] Implement indices for debug counters in VS (#531)
* Enable FastReboot if we have key "FAST_REBOOT|system" in State db (#529)
* [flex_counter] Add sairedis support for drop counters (#520)

swss:
* [orchagent] Add swss support for drop counters (#1075)
* [orchagent] warning fixes for 32bit arch compilation (#1129)
* [utilities] Create utility classes for interacting with flex counters (#1093)
* [portsorch] add support to set mac-address learning attribute on bridge-port (#809)
* Fix traceroute issue (#1113)

utilities:
* Add CLI support for configurable drop counters (#688)
* Revert "SONiC Management Framework Release 1.0 (#659)" (#741)
* SONiC Management Framework Release 1.0 (#659)

Signed-off-by: Danny Allen <[email protected]>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
@daall @zhenggen-xu
[submodule]: Update sairedis/swss/utilities (sonic-net#3786)
c8ef553 
sairedis:
* [SAI] Update SAI submodule to v1.5.1 (sonic-net#532)
* Cleanup Makefile.am from BFN specific code (sonic-net#530)
* [vs] Implement indices for debug counters in VS (sonic-net#531)
* Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529)
* [flex_counter] Add sairedis support for drop counters (sonic-net#520)

swss:
* [orchagent] Add swss support for drop counters (sonic-net#1075)
* [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129)
* [utilities] Create utility classes for interacting with flex counters (sonic-net#1093)
* [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809)
* Fix traceroute issue (sonic-net#1113)

utilities:
* Add CLI support for configurable drop counters (sonic-net#688)
* Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741)
* SONiC Management Framework Release 1.0 (sonic-net#659)

Signed-off-by: Danny Allen <[email protected]>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@daall @yxieca
[utilities] Create utility classes for interacting with flex counters (…
c7d8c2b 
…sonic-net#1093)

* [utilities] Create utility classes for interacting with flex counters
- Adds utility classes for interacting with flex counters
- Updates makefiles to support new utilities

Signed-off-by: Danny Allen <[email protected]>

* Reorganize helper classes

* Respond to PR feedback

* Fix stray includes

* Strip comma from end of string instead of beginning

* Fix build issue

* Fix style issues

* Add workaround for flex counter behavior
richardyu-ms added a commit to richardyu-ms/sonic-buildimage that referenced this pull request Jul 27, 2022
@richardyu-ms
Upgrade submodule sairedis
6c9f210 
Upgrade submodule sairedis to take the fix for saithrift build
Upgrade SAI to latest for building in bullseye (sonic-net#1093)

involve other changes in sairedis:
[sairedis] Fix reopen recoding file (sonic-net#1087)
Update PN with XPN support (sonic-net#1081)
[syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048)

Signed-off-by: richardyu-ms <[email protected]>
@richardyu-ms richardyu-ms mentioned this pull request Jul 27, 2022
Merged
7 tasks
lguohan pushed a commit that referenced this pull request Jul 28, 2022
@richardyu-ms
[submodule]: update sairedis (#11545)
8cc703f 
Upgrade submodule sairedis to take the fix for saithrift build
Upgrade SAI to latest for building in bullseye (#1093)

involve other changes in sairedis:
[sairedis] Fix reopen recoding file (#1087)
Update PN with XPN support (#1081)
[syncd] Remove error message when tryTranslateVidToRid fails (#1048)

Signed-off-by: richardyu-ms <[email protected]>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 23, 2022
@Gfrom2016
Merged PR 6536330: [submodule]: update sairedis (sonic-net#11545)
3fff015 
[submodule]: update sairedis (sonic-net#11545)

Upgrade submodule sairedis to take the fix for saithrift build
Upgrade SAI to latest for building in bullseye (sonic-net#1093)

involve other changes in sairedis:
[sairedis] Fix reopen recoding file (sonic-net#1087)
Update PN with XPN support (sonic-net#1081)
[syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048)

Signed-off-by: richardyu-ms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byu343 @prsunny @lguohan @jleveque