Make swssconfig status FATAL when it fails

[qiluo-msft]

Make supervisor controled one-shot program autorestart 0 time, so the status will become FATAL instead of EXITED if fails. 'supervisorctl status' differentiates between normal exit and failure.

It will help diagnose in running switch.

Signed-off-by: Qi Luo [email protected]

- What I did
The supervisor controlled one-shot program status will become FATAL instead of EXITED if failure happens
- How I did it
Make supervisor controled one-shot program autorestart 0 time
- How to verify it
Test in lab switch
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[stcheng]

what about set -e for this script?

[qiluo-msft]

The swssconfig.sh could be improved in future. Currently there is no assumption that every command will success there, except the obvious line such as sonic-cfggen.

[stcheng]

I didn't get why there's no assumption that every command will success? right now there're sonic-cfggen and swssconfig commands. I think both of them need to be successful after execution.

[jleveque]

What is the ultimate behavior change you're trying to achieve with this?

[stcheng]

please also check with other reviewers

[lguohan]

does this change the syslog message?

[qiluo-msft]

It only change syslog this way

Oct  4 06:25:42.643077 sonic INFO supervisord: start.sh neighsyncd: started
Oct  4 06:25:42.801254 sonic INFO swss.sh[26769]: 2017-10-04 06:25:42,800 INFO spawned: 'swssconfig' with pid 53
Oct  4 06:25:43.402113 sonic INFO supervisord: swssconfig Traceback (most recent call last):
Oct  4 06:25:43.402279 sonic INFO supervisord: swssconfig   File "/usr/local/bin/sonic-cfggen", line 215, in <module>
Oct  4 06:25:43.402502 sonic INFO supervisord: swssconfig     main()
Oct  4 06:25:43.402593 sonic INFO supervisord: swssconfig   File "/usr/local/bin/sonic-cfggen", line 196, in main
Oct  4 06:25:43.402676 sonic INFO supervisord: swssconfig     print template.render(data)
Oct  4 06:25:43.402755 sonic INFO supervisord: swssconfig   File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 1008, in render
Oct  4 06:25:43.403235 sonic INFO supervisord: swssconfig     return self.environment.handle_exception(exc_info, True)
Oct  4 06:25:43.403330 sonic INFO supervisord: swssconfig   File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 780, in handle_exception
Oct  4 06:25:43.403695 sonic INFO supervisord: swssconfig     reraise(exc_type, exc_value, tb)
Oct  4 06:25:43.403790 sonic INFO supervisord: swssconfig   File "/usr/share/sonic/templates/msn27xx.32ports.buffers.json.j2", line 209, in top-level template code
Oct  4 06:25:43.404032 sonic INFO supervisord: swssconfig     {%- set port_config = speed + '_' + cable -%}
Oct  4 06:25:43.404121 sonic INFO supervisord: swssconfig jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'speed'
Oct  4 06:25:43.423018 sonic INFO swss.sh[26769]: 2017-10-04 06:25:43,422 INFO exited: swssconfig (exit status 1; not expected)
Oct  4 06:25:44.424811 sonic INFO swss.sh[26769]: 2017-10-04 06:25:44,424 INFO gave up: swssconfig entered FATAL state, too many start retries too quickly
Oct  4 06:25:44.428831 sonic INFO supervisord: start.sh swssconfig: ERROR (spawn error)