Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpam: Block sshd's INCORRECT password to AAA server #10029

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

renukamanavalan
Copy link
Contributor

Why I did it

sshd overrides user password with a bad one, when pre-auth fails.
Refer PR #9123 for more details

How I did it

Manual cherry pick of PR #9123

How to verify it

  1. Pick a user alias that has not logged into the switch yet
  2. Add this alias to /etc/tacplus_user
  3. Attempt to login as that user
  4. Look for the error message in /var/log/syslog
    e.g. "Feb 18 19:16:41.592191 sonic ERR sshd[5233]: auth fail: Password incorrect. user: user_xyz"

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Identify the bad password set by sshd and fail auth before sending to AAA
server, and hence avoid possible user lock out by AAA
For more details, please refer the parent/original PR sonic-net#9123
@renukamanavalan renukamanavalan self-assigned this Feb 18, 2022
@renukamanavalan renukamanavalan merged commit ca7d730 into sonic-net:201811 Feb 19, 2022
@renukamanavalan renukamanavalan deleted the pam_201811 branch August 17, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants