Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecnconfig] Exception while displaying ecn status on queue #8323

Closed
neethajohn opened this issue Aug 3, 2021 · 0 comments · Fixed by sonic-net/sonic-utilities#1784
Closed

[ecnconfig] Exception while displaying ecn status on queue #8323

neethajohn opened this issue Aug 3, 2021 · 0 comments · Fixed by sonic-net/sonic-utilities#1784
Assignees
@neethajohn
Labels
Issue for 202012 Master Branch Quality

Comments

@neethajohn
Copy link
Contributor

Description

admin@sonic:~$ ecnconfig -q 3
Exception caught: 'dict_keys' object has no attribute 'sort'

Steps to reproduce the issue:

  1. Issue the command mentioned above and the error should be seen

Describe the results you received:

Exception caught: 'dict_keys' object has no attribute 'sort'

Describe the results you expected:

admin@sonic:~$ ecnconfig -q 3
ECN status:
queue 3: on

Output of show version:

SONiC Software Version: SONiC.20201231.11
Distribution: Debian 10.10
Kernel: 4.19.0-12-2-amd64
Build commit: 772c9bb4f3
Build date: Thu Jul 29 11:56:34 UTC 2021
Built by: AzDevOps@sonic-int-build-workers-0002DZ

Platform: x86_64-arista_7050_qx32s
HwSKU: Arista-7050-QX-32S
ASIC: broadcom
ASIC Count: 1
Serial Number: JPE20255843
Uptime: 23:13:46 up 1 day,  2:44,  1 user,  load average: 0.37, 0.30, 0.35

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-syncd-brcm          20201231.11         29c42b347626        694MB
docker-syncd-brcm          latest              29c42b347626        694MB
docker-teamd               20201231.11         45b0c81dd6b6        412MB
docker-teamd               latest              45b0c81dd6b6        412MB
docker-router-advertiser   20201231.11         0d0dbd3712d9        401MB
docker-router-advertiser   latest              0d0dbd3712d9        401MB
docker-platform-monitor    20201231.11         c810e97477fd        609MB
docker-platform-monitor    latest              c810e97477fd        609MB
docker-lldp                20201231.11         b233c314e9fc        441MB
docker-lldp                latest              b233c314e9fc        441MB
docker-snmp                20201231.11         08ace26c7631        443MB
docker-snmp                latest              08ace26c7631        443MB
docker-database            20201231.11         dc211f5c3dae        401MB
docker-database            latest              dc211f5c3dae        401MB
docker-orchagent           20201231.11         f91913ebde38        430MB
docker-orchagent           latest              f91913ebde38        430MB
docker-dhcp-relay          20201231.11         3cb3d26cefe6        408MB
docker-dhcp-relay          latest              3cb3d26cefe6        408MB
docker-sonic-telemetry     20201231.11         4c7cd8d8090e        491MB
docker-sonic-telemetry     latest              4c7cd8d8090e        491MB
docker-fpm-frr             20201231.11         db539af8c90b        430MB
docker-fpm-frr             latest              db539af8c90b        430MB
@neethajohn neethajohn self-assigned this Aug 3, 2021
@neethajohn neethajohn mentioned this issue Aug 27, 2021
Merged
neethajohn added a commit to sonic-net/sonic-utilities that referenced this issue Aug 30, 2021
@neethajohn
[ecnconfig] Fix exception seen during display and add unit tests (#1784)
3e8626e 
Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs.

Signed-off-by: Neetha John <[email protected]>

How to verify it
Ran tests/ecn_test.py and all cases passed
neethajohn added a commit to neethajohn/sonic-utilities that referenced this issue Aug 30, 2021
@neethajohn
[ecnconfig] Fix exception seen during display and add unit tests (son…
442db36 
…ic-net#1784)

Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs.

Signed-off-by: Neetha John <[email protected]>

How to verify it
Ran tests/ecn_test.py and all cases passed
judyjoseph pushed a commit to sonic-net/sonic-utilities that referenced this issue Sep 2, 2021
@neethajohn @judyjoseph
[ecnconfig] Fix exception seen during display and add unit tests (#1784)
2c6a15e 
Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs.

Signed-off-by: Neetha John <[email protected]>

How to verify it
Ran tests/ecn_test.py and all cases passed
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
@malletvapid23
[ecnconfig] Fix exception seen during display and add unit tests (#1784)
ceed899 
Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs.

Signed-off-by: Neetha John <[email protected]>

How to verify it
Ran tests/ecn_test.py and all cases passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neethajohn neethajohn

Labels
Issue for 202012 Master Branch Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ecnconfig] Fix exception seen during display and add unit tests neethajohn/sonic-utilities
1 participant
@neethajohn