Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_cacl_application failing due to recent change in caclmgrd #12464

Closed
SuvarnaMeenakshi opened this issue Oct 20, 2022 · 1 comment
Closed

test_cacl_application failing due to recent change in caclmgrd #12464

SuvarnaMeenakshi opened this issue Oct 20, 2022 · 1 comment
Assignees
@SuvarnaMeenakshi
Labels
Triaged this issue has been triaged

Comments

@SuvarnaMeenakshi
Copy link
Contributor

Description

Steps to reproduce the issue:

  1. Bring up testbed with latest sonic-buildimage master and master branch of sonic-host-services submodule.
  2. run test_cacl_application.

Describe the results you received:

below failure is seen:

=================================== FAILURES ===================================
__________________ test_cacl_application_nondualtor[vlab-01] ___________________

duthosts = [<MultiAsicSonicHost vlab-01>]
tbinfo = {'auto_recover': 'False', 'comment': 'Tests virtual switch vm', 'conf-name': 'vms-kvm-t0', 'duts': ['vlab-01'], ...}
enum_rand_one_per_hwsku_hostname = 'vlab-01'
localhost = <tests.common.devices.local.Localhost object at 0x7fde503e8b10>
creds = {'ansible_become_pass': 'password', 'ansible_ssh_pass': 'password', 'ansible_ssh_user': 'user', 'bgp_slb_passive_range': '10.255.0.0/25', ...}
docker_network = {'bridge': {'IPv4Address': '240.127.1.1', 'IPv6Address': 'fd00::/80'}, 'container': {}}

    def test_cacl_application_nondualtor(duthosts, tbinfo, enum_rand_one_per_hwsku_hostname, localhost, creds, docker_network):
        """

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

Fix is required so that latest branch of sonic-host-services submodule is merged into sonic-buildimage master branch.
Issue is seen after merging sonic-net/sonic-host-services#6
@SuvarnaMeenakshi SuvarnaMeenakshi added the Triaged this issue has been triaged label Oct 20, 2022
This was referenced Oct 20, 2022
Merged
Merged
SuvarnaMeenakshi added a commit to sonic-net/sonic-mgmt that referenced this issue Oct 21, 2022
@SuvarnaMeenakshi
Skip test_cacl_application to unblock sub module update of sonic-host…
b9e8b16 
…-services (#6585)

What is the motivation for this PR?
Recent change in caclmgrd caused the expected ACL list to change.
test_cacl_application fails because the expected ACLs are not present on DUT.
This is occurring with latest sonic-host-services changes, and is blocking sub module update.
Test case has to be updated, but updated test case will fail without the latest changes from sonic-host-services. This PR is to ensure that sub module is updated so that the test case can pass.
issue: sonic-net/sonic-buildimage#12464
submodule update PR that is blocked: sonic-net/sonic-buildimage#12195

How did you do it?
skip test_cacl_application.
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this issue Oct 28, 2022
@SuvarnaMeenakshi
Skip test_cacl_application to unblock sub module update of sonic-host…
4e93235 
…-services (sonic-net#6585)

What is the motivation for this PR?
Recent change in caclmgrd caused the expected ACL list to change.
test_cacl_application fails because the expected ACLs are not present on DUT.
This is occurring with latest sonic-host-services changes, and is blocking sub module update.
Test case has to be updated, but updated test case will fail without the latest changes from sonic-host-services. This PR is to ensure that sub module is updated so that the test case can pass.
issue: sonic-net/sonic-buildimage#12464
submodule update PR that is blocked: sonic-net/sonic-buildimage#12195

How did you do it?
skip test_cacl_application.
@SuvarnaMeenakshi SuvarnaMeenakshi self-assigned this Nov 12, 2022
@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this issue Dec 21, 2022
Merged
6 tasks
SuvarnaMeenakshi added a commit to sonic-net/sonic-mgmt that referenced this issue Dec 28, 2022
@SuvarnaMeenakshi
Remove MGMT_INTERFACE from ip2me block rule list (#7092)
14768ea 
What is the motivation for this PR?
Provides fix for sonic-net/sonic-buildimage#12464
MGMT_INTERFACE was removed from default ip2me block rules in PR sonic-net/sonic-host-services#6
This PR is to modify the test case according to the change in caclmgrd

How did you do it?
Remove MGMT_INTERFACE when generating ip2me block rule list.

How did you verify/test it?
Ran test on multi-asic vs DUT, without skipping this test:
..
cacl/test_cacl_application.py::test_cacl_application_nondualtor[vlab-08-1]
PASSED [ 70%]
cacl/test_cacl_application.py::test_cacl_application_dualtor[active_tor-vlab-08-1] SKIPPED [ 80%]
cacl/test_cacl_application.py::test_cacl_application_dualtor[standby_tor-vlab-08-1] SKIPPED [ 90%]
cacl/test_cacl_application.py::test_multiasic_cacl_application[vlab-08-1]
PASSED
SKIPPED [4] cacl/test_cacl_application.py: test_cacl_application_dualtor is only supported on dualtor topology
SKIPPED [1] cacl/test_cacl_application.py: caclmgrd may crash after loading scale ipv4 cacl rules.
SKIPPED [1] cacl/test_cacl_application.py: caclmgrd may crash after loading scale ipv6 cacl rules.
============================================================================================================ 4 passed, 6 skipped in 769.78 seconds =============================================================================================================
@SuvarnaMeenakshi
Copy link
Contributor Author

sonic-net/sonic-mgmt#7092 fixes this issue

@ZhaohuiS ZhaohuiS mentioned this issue Feb 1, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuvarnaMeenakshi SuvarnaMeenakshi

Labels
Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SuvarnaMeenakshi