Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image build should fail if debian packages or python wheels fail to install #1012

Closed
jleveque opened this issue Oct 4, 2017 · 3 comments
Closed

Image build should fail if debian packages or python wheels fail to install #1012

jleveque opened this issue Oct 4, 2017 · 3 comments
Assignees
@qiluo-msft
Labels
Enhancement ➕

Comments

@jleveque
Copy link
Contributor

jleveque commented Oct 4, 2017

Take this issue, for instance: sonic-net/SONiC#113

In this case, the sonic-utilities package fails to get installed due to dependency issues, however, the image build continues and "succeeds" even though the image doesn't contain the necessary sonic-utilities package.

We need a solution to cause the image build to fail in error in instances such as this.
@stcheng
Copy link
Contributor

stcheng commented Oct 5, 2017

one side effect caused by this is that the sonic_installer is not correctly installed. Ansible will not be able to upgrade this system automatically.

@lguohan
Copy link
Collaborator

lguohan commented Oct 19, 2018

add -e in the build_debian.sh and extension.sh and check.

@qiluo-msft
Copy link
Collaborator

This issue should be there anymore.

dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this issue Oct 29, 2019
Updating the sonic-swss submodule pointer
3b334d6 
20747fa -2019-10-28: Sflow orchagent changes (sonic-net#1012) [Sudharsan]
b767ca2 -2019-10-28: Copp sflow changes (sonic-net#1011)[Sudharsan]
@dgsudharsan dgsudharsan mentioned this issue Oct 29, 2019
Merged
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@prsunny
Sflow orchagent changes (sonic-net#1012)
20747fa 
* Sflow orchagent changes
lguohan added a commit to lguohan/sonic-buildimage that referenced this issue Aug 5, 2020
@lguohan
[submodule]: update sonic-utilities
b1f2a4e 
* 9700e45 2020-08-03 | [show/config]: combine feature and container feature cli (sonic-net#1015) (HEAD, origin/master, origin/HEAD) [lguohan]
* c9d3550 2020-08-03 | [tests]: fix drops_group_test failure on second run (sonic-net#1023) [lguohan]
* dfaae69 2020-08-03 | [lldpshow]: Fix input device is not a TTY error (sonic-net#1016) [Arun Saravanan Balachandran]
* 216688e 2020-08-02 | [tests]: rename sonic-utilitie-tests to tests (sonic-net#1022) [lguohan]
* c0c3cce 2020-07-30 | [config/config_mgmt.py]: Fix typo and enable test for tablesWithOutYang() (sonic-net#1012) [Praveen Chaudhary]
* c6c5be1 2020-07-30 | [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002) [shlomibitton]
* ef9ac2a 2020-07-29 | importing json needed for DPB CLI (sonic-net#1010) [Sangita Maity]
* aa1b072 2020-07-23 | [config] Add Initial draft of Breakout Mode subcommand (sonic-net#766) [Sangita Maity]
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
[config/config_mgmt.py]: Fix typo and enable test for tablesWithOutYa…
c0c3cce 
…ng() (sonic-net#1012)

Fix typo and enable test for tablesWithOutYang()

Signed-off-by: Praveen Chaudhary [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiluo-msft qiluo-msft

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lguohan @stcheng @jleveque @qiluo-msft